-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v0.44.x] Fix spammy logs #6780
[release-v0.44.x] Fix spammy logs #6780
Conversation
A couple of lines are causing a lot of spam in the controller logs: - logging the content of steps - logging that the cache client cannot be find, which is expected since the cache is only available in the Run/CustomRun controller and not for TaskRun and PipelineRun controllers Signed-off-by: Andrea Frittoli <andrea.frittoli@uk.ibm.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/retest
|
/kind misc |
I guess we need to manually fix and patch this? |
@Yongxuanzhang I think we need to do something so that we don't get unrelated failure when we do these cherry-picks. All the jobs are not versioned per branch, so changes to their definition to accommodate the |
This failure is happening in #6787 as well but I unfortunately wasn't able to reproduce it locally. Do any of you know whether these tests are actually fetching from a real GCS bucket gs://build-crd-tests (which doesn't exist) or whether there's a local gcs (?) of some sort, similar to how we use in-cluster image registries? |
The example has been removed, could it be the corresponding resource was removed as well? So we cannot pass it now |
The example and functionality were removed in #6150, which made it into the v0.46 release. I'm not sure why this functionality would fail on the v0.44.x branch. |
I think I reproduced this issue when I apply the v0.41 pipeline and then create the taskrun.
log:
|
There is also this 🤔 |
/retest |
I think we can "just" move this example test into "no-ci" for now 🐼 |
Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/lgtm |
:o I did not know you could push commits to others' PRs |
+1, how did you do that :O |
@lbernick @Yongxuanzhang this is a github feature. As maintainers, if the author of the PR allows us to do it (which is by default), it's relatively easy to do. $ gh checkout pr 6780
# […] do your thing
$ git commit -sS -m "…"
$ git push And it just works 😝 |
This is an automated cherry-pick of #6051
/assign lbernick