Refactor TestReconcile_RemotePipelineRef bundle resolver test case #6781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
JeromeJu
force-pushed
the
refactor-pr-reconciler
branch
from
fe9ac93
to
93e16eb
Compare
|
/kind cleanup |
tekton-robot
added
the
kind/cleanup
JeromeJu
force-pushed
the
refactor-pr-reconciler
branch
3 times, most recently
from
e9ab1d7
to
63cff90
Compare
|
/assign @lbernick @Yongxuanzhang |
Yongxuanzhang
approved these changes
Jun 6, 2023
| } | ||
|
|
||
| pipelineReq := getResolvedResolutionRequest(t, "bar", pipelineBytes, "foo", prName) |
There was a problem hiding this comment.
nit: I think we could create a var for the "bar" resolver. And use it in task, pipeline and here.
|
I think this PR goes to v1 swap's work? Maybe link it to the issue where we track the progress. |
lbernick
approved these changes
Jun 6, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick, Yongxuanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This commit refactors the v1beta1 bundle syntax which is deprecated in v1 for the TestReconcile_RemotePipelineRef test case. It moves the taskref and pipelineref off OCI bundle since the test case is based on a remote pipelineRef.
JeromeJu
force-pushed
the
refactor-pr-reconciler
branch
from
63cff90
to
c94a02d
Compare
|
This would be a cleanup for #6444 |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit refactors the v1beta1 bundle syntax which is deprecated in v1 for the TestReconcile_RemotePipelineRef test
case. It moves the taskref and pipelineref off OCI bundle since the test case is based on a remote pipelineRef.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes