Remove logic setting resolvers feature flag in e2e tests #6786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/bug
tekton-robot
added
the
size/S
|
/assign |
lbernick
changed the title
|
/hold |
tekton-robot
added
the
do-not-merge/hold
Resolution is a beta feature, and resolvers are now enabled by default. Therefore, there is no logic needed to patch the resolvers configmap when "enable-api-fields" is set to "stable". In addition, we don't gate installation of resolvers on the "enable-api-fields" feature flag, and doing so in tests isn't representative of how users install resolvers. This commit removes logic patching the resolvers configmap.
lbernick
force-pushed
the
resolver-beta
branch
3 times, most recently
from
2e280ff
to
437c5a2
Compare
lbernick
added
kind/cleanup
lbernick
force-pushed
the
resolver-beta
branch
2 times, most recently
from
2e280ff
to
deca6a2
Compare
JeromeJu
approved these changes
Jun 12, 2023
|
/lgtm |
dibyom
approved these changes
Jun 12, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, JeromeJu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
|
beta tests: #4169 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution is a beta feature, and resolvers are now enabled by default.
Therefore, there is no logic needed to patch the resolvers configmap when "enable-api-fields" is set to "stable".
In addition, we don't gate installation of resolvers on the "enable-api-fields" feature flag,
and doing so in tests isn't representative of how users install resolvers.
This commit removes logic patching the resolvers configmap.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes