[Draft] Validate Emitted Results from a Pipeline Task

[EmmaMunley]

Changes

This commit adds validation logic in the TaskRun reconciler to ensure that any results defined within a PipelineSpec are actually produced.

Note this is just a draft and still has failing e2e tests that need to be addressed.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign abayer after the PR has been reviewed.
You can assign the PR to them by writing /assign @abayer in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tekton-robot]

The following Tekton test failed:

Test name	Commit	Details	Required	Rerun command
check-pr-has-kind-label	0c43ce9	link	true	/test check-pr-has-kind-label

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/validate_taskrun.go	100.0%	96.1%	-3.9

[EmmaMunley]

/test all

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/taskrun/validate_taskrun.go	100.0%	96.1%	-3.9

[tekton-robot]

@EmmaMunley: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-pipeline-integration-tests	0c43ce9	link	true	/test pull-tekton-pipeline-integration-tests
pull-tekton-pipeline-build-tests	0c43ce9	link	true	/test pull-tekton-pipeline-build-tests
pull-tekton-pipeline-beta-integration-tests	0c43ce9	link	true	/test pull-tekton-pipeline-beta-integration-tests
pull-tekton-pipeline-alpha-integration-tests	0c43ce9	link	true	/test pull-tekton-pipeline-alpha-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tekton-robot]

@EmmaMunley: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[jerop]

@EmmaMunley please feel free to reopen this PR when you pick up this work

/close

(cleaning up old pull requests)

[tekton-robot]

@jerop: Closed this PR.

In response to this:

@EmmaMunley please feel free to reopen this PR when you pick up this work

/close

(cleaning up old pull requests)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.