Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion webhook fix for tasks with nil StepTemplate #6825

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversion webhook fix for tasks with nil StepTemplate #6825

merged 1 commit into from
Jun 13, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Jun 13, 2023 •
edited
Loading

Prior to this, the conversion of task spec from v1beta1 was panicing when the step template was nil since it could not access the underlying deprecated fields. This PR fixes that bug. Related issue: #6823

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Conversion webhook fix for tasks with nil StepTemplate

/kind bug

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jun 13, 2023
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 13, 2023
@chitrangpatel chitrangpatel mentioned this pull request Jun 13, 2023
Closed
@chitrangpatel
Copy link
Contributor Author

/assign @lbernick

@lbernick
Copy link
Member

can you please add tests for your change?

@chitrangpatel
Copy link
Contributor Author

can you please add tests for your change?

Yes, your example should help.

@chitrangpatel
Copy link
Contributor Author

/hold adding tests

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_conversion.go 92.5% 92.6% 0.1

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_conversion.go 92.5% 92.6% 0.1

@chitrangpatel chitrangpatel force-pushed the Issue-6823-conversion-webhook-panic branch from 644f8bc to b8e1776 Compare June 13, 2023 15:22
@chitrangpatel
Copy link
Contributor Author

/hold cancel

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 13, 2023
@chitrangpatel
Copy link
Contributor Author

can you please add tests for your change?

Yes, your example should help.

Done!

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_conversion.go 92.5% 93.2% 0.8

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_conversion.go 92.5% 93.2% 0.8

@JeromeJu
Copy link
Member

/assign

lbernick
lbernick approved these changes Jun 13, 2023
View reviewed changes
pkg/apis/pipeline/v1beta1/task_conversion.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@chitrangpatel
Issue-6823 Conversion Webhook panic fix
7a01290 
Prior to this, the conversion of task spec from v1beta1
was panicing when the step template was nil since it could not
access the underlying deprecated fields. This PR fixes that bug.
Related issue: tektoncd#6823
@chitrangpatel chitrangpatel force-pushed the Issue-6823-conversion-webhook-panic branch from b8e1776 to 7a01290 Compare June 13, 2023 15:47
@JeromeJu
Copy link
Member

/lgtm
thanks for the fix @chitrangpatel

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_conversion.go 92.5% 93.2% 0.7

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_conversion.go 92.5% 93.2% 0.7

@tekton-robot tekton-robot merged commit fb292df into tektoncd:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbernick lbernick lbernick approved these changes

@abayer abayer Awaiting requested review from abayer

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@lbernick lbernick

@JeromeJu JeromeJu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chitrangpatel @lbernick @tekton-robot @JeromeJu