Bump knative/pkg to 1.10 #6907
Bump knative/pkg to 1.10 #6907
Conversation
tekton-robot
added
kind/misc
tekton-robot
added
the
size/L
This comes with a challenge, which is `k8s.io` dependencies, and thus `replace` is coming back in the picture (sadly). This will have to be fixed once `knative/pkg` k8s.io dependencies are up-to-date or at least *compatible* with the rest of the library we use (`go-containerregistry` is the example today). This is tracked in knative/pkg here : knative/pkg#2759. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
bump-knative-pkg
branch
from
1c74ccf
to
3e71cfb
Compare
| @@ -22,7 +22,7 @@ source $(git rev-parse --show-toplevel)/vendor/github.com/tektoncd/plumbing/scri | |||
|
|
|||
| cd ${REPO_ROOT_DIR} | |||
|
|
|||
| KNATIVE_VERSION="release-1.9" | |||
| KNATIVE_VERSION="release-1.10" | |||
There was a problem hiding this comment.
curious how you figured out which version tag corresponded to the tag release-1.10? When I looked, I saw a branch release-1.10 on the github repo, and a few versions on pkg.go.dev, but couldn't figure out which was which.
There was a problem hiding this comment.
I am not looking at the tag but at the branches (as doesn't use tags at all). go get … and go mod … work with branches as well as tags 👼🏼, and not looking at pkg.go.dev at all either 🙃
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeromeJu, lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This comes with a challenge, which is
k8s.iodependencies, and thusreplaceis comingback in the picture (sadly). This will have to be fixed once
knative/pkgk8s.iodependencies are up-to-date or at least compatible with the rest of the library we use
(
go-containerregistryis the example today).This is tracked in knative/pkg here : knative/pkg#2759.
This should help unblocking the rest of the dependabot PRs as well.
It also doesn't change the kubernetes min version if I am not mistaken.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes