Deduplicate examples tests between v1 and v1beta1 #6908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XXL
lbernick
force-pushed
the
remove-examples
branch
3 times, most recently
from
8584a51
to
a9be783
Compare
jerop
reviewed
Jul 7, 2023
There was a problem hiding this comment.
examples are not only used for tests but also as samples for users (with some of them even being referenced in the docs) -- instead of removing them, can we move them to the folder where they are not tested so that they can still be used as samples? the concern here though is that they may go out of date if they are not tested :/
|
reading the description of this PR again, you are not actually removing any tests because there are integration tests for the same functionality, you are only deduplicating v1 and v1beta1 -- is that correct? if so, I suggest updating the title to "deduplicate example tests in v1beta1 and v1" reading #6906 and the title made me think that you were actually removing tests -- thought the redundancy is with integration tests please clarify |
lbernick
changed the title
|
Thanks for the feedback, updated the PR title and commit message! |
jerop
approved these changes
Jul 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm Thanks! Not sure if in docs we linked to examples moved in this PR, but should be easy to fix if there is any |
Currently, we run a large number of examples tests that are duplicated in v1 and v1beta1. These tests are meant to test specific features, such as params and workspaces, that have the same syntax and implementation in v1 and v1beta1. Since we have conversion integration tests, these duplicated examples tests are likely adding little value. In addition, examples tests are the flakiest set of tests in the repo and often time out. Removing redundant examples tests should make our CI less flaky. This commit moves any examples tests that were solely present in v1beta1 to v1, leaving only those that use features that weren't migrated to v1. It deletes any examples that were duplicated between v1 and v1beta1.
lbernick
force-pushed
the
remove-examples
branch
from
10ea0a2
to
317ca29
Compare
|
/lgtm |
HamzaMateen
added a commit
to HamzaMateen/pipeline
that referenced
this pull request
Aug 12, 2023
In response to the cleanup effort aimed at deduplicating tests between v1 and v1beta1, this commit addresses broken links in our documentation. The changes involve updating references to examples under the v1beta1 API version to instead point to the v1 API version. Additionally, certain features that transitioned from alpha to beta within the v1 API required corresponding updates to their references. This change ensures that the documentation accurately reflects the current state of the project, eliminating broken links and inconsistencies. The goal is to improve the overall user experience and provide accurate information. Fixes tektoncd#6908
3 tasks
tekton-robot
pushed a commit
that referenced
this pull request
Aug 15, 2023
In response to the cleanup effort aimed at deduplicating tests between v1 and v1beta1, this commit addresses broken links in our documentation. The changes involve updating references to examples under the v1beta1 API version to instead point to the v1 API version. Additionally, certain features that transitioned from alpha to beta within the v1 API required corresponding updates to their references. This change ensures that the documentation accurately reflects the current state of the project, eliminating broken links and inconsistencies. The goal is to improve the overall user experience and provide accurate information. Fixes #6908
tekton-robot
pushed a commit
to tekton-robot/pipeline
that referenced
this pull request
Oct 11, 2023
In response to the cleanup effort aimed at deduplicating tests between v1 and v1beta1, this commit addresses broken links in our documentation. The changes involve updating references to examples under the v1beta1 API version to instead point to the v1 API version. Additionally, certain features that transitioned from alpha to beta within the v1 API required corresponding updates to their references. This change ensures that the documentation accurately reflects the current state of the project, eliminating broken links and inconsistencies. The goal is to improve the overall user experience and provide accurate information. Fixes tektoncd#6908
tekton-robot
pushed a commit
that referenced
this pull request
Oct 11, 2023
In response to the cleanup effort aimed at deduplicating tests between v1 and v1beta1, this commit addresses broken links in our documentation. The changes involve updating references to examples under the v1beta1 API version to instead point to the v1 API version. Additionally, certain features that transitioned from alpha to beta within the v1 API required corresponding updates to their references. This change ensures that the documentation accurately reflects the current state of the project, eliminating broken links and inconsistencies. The goal is to improve the overall user experience and provide accurate information. Fixes #6908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we run a large number of examples tests that are duplicated in v1 and v1beta1. These tests are meant to test specific features, such as params and workspaces, that have the same syntax and implementation in v1 and v1beta1. Since we have conversion integration tests, these duplicated examples tests are likely adding little value.
In addition, examples tests are the flakiest set of tests in the repo and often time out. Removing redundant examples tests should make our CI less flaky.
This commit moves any examples tests that were solely present in v1beta1 to v1, leaving only those that use features that weren't migrated to v1. It deletes any examples that were duplicated between v1 and v1beta1.
/kind cleanup
Partially addresses #6906
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes