Fix enforce-nonfalsifiability feature flag in configmap #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note-none
tekton-robot
added
lgtm
Seems like there may be an issue pulling metallb images? going to try one more time |
tekton-robot
added
size/S
Prior to this commit, the feature-flags configmap installed with Tekton pipelines contained a misspelling of the flag "enforce-nonfalsifiability". Editing this flag would have no effect. This commit fixes the typo in the flag name. In addition, prior to this commit, spire support was disabled when "enforce-nonfalsifiability" was set to "", but documentation and the feature-flags configmap stated that spire should be disabled when the feature flag is set to "none". This commit aligns the implementation with the documentation. This feature flag is not yet functional.
tekton-robot
added
size/M
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the feature-flags configmap installed with Tekton pipelines contained a misspelling of the flag "enforce-nonfalsifiability". Editing this flag would have no effect. This commit fixes the typo in the flag name.
In addition, prior to this commit, spire support was disabled when "enforce-nonfalsifiability" was set to "", but documentation and the feature-flags configmap stated that spire should be disabled when the feature flag is set to "none". This commit aligns the implementation with the documentation.
This feature flag is not yet functional.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes