[release-v0.50.x] Make sure we use the correct namespace for remote Pipeline validation #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of using the cluster resolver, the fetched `Pipeline` will have a namespace attached to it, which **will** be different from the current namespace (where the `PipelineRun` is applied). This causes the following error when using the cluster resolver: ``` validation failed for referenced Pipeline pipeline-name: the namespace of the provided object does not match the namespace sent on the request ``` This make sure we use the PipelineRun's namespace namespace when doing the remote `Pipeline` validation. This fixes tektoncd#7015. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
7 tasks
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
|
/kind bug |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #7017
/assign vdemeester