Upgraded Remote Resolution Framework #7910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
kind/misc
|
/assign @wlynch |
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
wlynch
reviewed
Apr 24, 2024
chitrangpatel
force-pushed
the
resolver-refactor
branch
from
c6d6698 to
68b9bd3
Compare
8 tasks
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
resolver-refactor
branch
from
68b9bd3 to
260ba20
Compare
tekton-robot
added
size/XXL
tekton-robot
added
release-note
chitrangpatel
changed the title
chitrangpatel
force-pushed
the
resolver-refactor
branch
from
260ba20 to
7d0c732
Compare
|
The following is the coverage report on the affected files.
|
|
/assign @afrittoli if you have a chance, PTAL! |
wlynch
requested changes
Apr 30, 2024
chitrangpatel
force-pushed
the
resolver-refactor
branch
from
7d0c732 to
1396119
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
resolver-refactor
branch
from
28e6682 to
e2711da
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
chitrangpatel
force-pushed
the
resolver-refactor
branch
from
e2711da to
f166f17
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
afrittoli
reviewed
May 14, 2024
...solution/resolver/git/testdata/test-org/test-repo/refs/other/pipelines/example-pipeline.yaml
Outdated
Show resolved
Hide resolved
chitrangpatel
force-pushed
the
resolver-refactor
branch
2 times, most recently
from
4c1e478 to
0a88237
Compare
afrittoli
reviewed
May 14, 2024
This PR implements an updated resolver framework with slight updates. This is to avoid backwards incompatibility while implementing [TEP-0154](tektoncd/community#1138). The current framework only works with Params. e.g. The interface has ValidateParams and Resolve which takes in Params. Now that we also need to pass in a `URL`, we need to add new methods and change function signatures which leads to API incompatibility with existing custom resolvers. As a result, when users upgrade to new version of Tekton Pipelines, they will be forced to be compatible with the new format because of the interface changes. This PR tries to make it future proof such that if we add new fields to the ResolutionSpec, it will be handled without the need to break users.
chitrangpatel
force-pushed
the
resolver-refactor
branch
from
0a88237 to
b5e8ca2
Compare
|
The following is the coverage report on the affected files.
|
afrittoli
reviewed
May 14, 2024
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an updated resolver framework with slight updates. This is to avoid backwards incompatibility while implementing TEP-0154.
The current framework works directly with
Params. For example, the interface hasValidateParamsandResolvemethods which take inParamsas arguments. Now that we also need to pass in aURL, we need to add new methods and change function signatures which leads to API incompatibility with existing custom resolvers. As a result, when users upgrade to new version of Tekton Pipelines, they will be forced to implement new methods because of the interface changes.This PR tries to make it future proof such that if we add new fields to the
ResolutionRequestSpec, it will be handled without the need to break users.Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind misc