-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEP0152 - Complete V1 conformance test suite #7913
Conversation
This commit adds conformance test for Step.
For clarity and easy to read, I would suggest moving the yamls to individual files under |
/approve |
Adding some outputs for the offline discussion we had - this is not done as fof the case of this PR mainly because we are having customized inputs for the YAML (which, potentially, could cause invalid YAML error with '%s' inputs in the files if we separate them out in different files). cc @tektoncd/core-maintainers @tektoncd/core-collaborators PTAL 🙏 |
cc @tektoncd/core-maintainers can i have a lgtm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This PR consists of the V1
REQUIRED
fields for v1 conformance.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes