Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to go 1.22 and fixes #8035

Merged
merged 6 commits into from
Jun 18, 2024
Merged

Bump to go 1.22 and fixes #8035

merged 6 commits into from
Jun 18, 2024

Commits on Jun 18, 2024

  1. go.mod: switch go version to 1.22 

    This will unblock some dependencies updates (such as go-scm)

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
    @vdemeester
    vdemeester committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    fa8fc5d View commit details
    Browse the repository at this point in the history

  2. go.mod: remove k8s.io replace directive 

    upstream knative/pkg seem to have fixed the issue refered in the
comment, so let's delete this.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
    @vdemeester
    vdemeester committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9bd8ce5 View commit details
    Browse the repository at this point in the history

  3. golangci-lint: exclude G601 from gosec 

    The idea is to not get false positive.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
    @vdemeester
    vdemeester committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    57697a6 View commit details
    Browse the repository at this point in the history

  4. Update golangci-lint to 1.59.x and fix linting 

    This mainly removing the need to copy variable in a for loop to
capture rang as it is now "fixed" in go 1.22+.

> The copy of the 'for' variable "td" can be deleted (Go
1.22+) (copyloopvar)

This also fixes some fatcontext issues, for loop range, …

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
    @vdemeester
    vdemeester committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4a161eb View commit details
    Browse the repository at this point in the history

  5. .github/workflow: use setup-go in codeql-analysis 

    This is to ensure it installs the correct go toolchain version we need
to build the project.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
    @vdemeester
    vdemeester committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    0039973 View commit details
    Browse the repository at this point in the history

  6. Makefile: install golangci-lint version from tools/go.mod 

    And "version" the binary so we *ensure* that it doesn't execute an
older version of `golangci-lint` when we update the dependency.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
    @vdemeester
    vdemeester committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7ff2c93 View commit details
    Browse the repository at this point in the history