Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests before promoting LargerResults via Sidecarlogs to Beta #8041

Merged

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Jun 10, 2024

#6133 identified missing example/e2e tests to complete before promoting Larger Results via Sidecar Logs to Beta. This PR updates the e2e tests with:

  • Multiple Tasks with Multiple Results in a Pipeline
  • A Step producing Result fails with OnError continue
  • A Failed Task in the Pipeline

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind test

tektoncd#6133 identified missing
example/e2e tests to complete before promoting Larger Results via
Sidecar Logs to Beta. This PR updates the e2e tests with:
* Multiple Tasks with Multiple Results in a  Pipeline
* A Step producing Result fails with OnError continue
* A Failed Task in the Pipeline
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jun 10, 2024
@tekton-robot
Copy link
Collaborator

@chitrangpatel: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

#6133 identified missing example/e2e tests to complete before promoting Larger Results via Sidecar Logs to Beta. This PR updates the e2e tests with:

  • Multiple Tasks with Multiple Results in a Pipeline
  • A Step producing Result fails with OnError continue
  • A Failed Task in the Pipeline

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

/kind test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 10, 2024
@chitrangpatel
Copy link
Contributor Author

/kind testing

@chitrangpatel
Copy link
Contributor Author

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jun 10, 2024
@chitrangpatel chitrangpatel added this to the Pipeline v0.61 milestone Jun 10, 2024
@chitrangpatel
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JeromeJu, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JeromeJu,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JeromeJu
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
@chitrangpatel
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot merged commit 351cb9a into tektoncd:main Jun 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants