SRVKP-6184 - Add Running PipelineRuns metric for Pipeline and Namespace. #8242

pramodbindal · 2024-09-05T11:32:41Z

Changes

Updated metric Running PipelineRuns to include namespace and pipeline

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
pre-commit Passed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

linux-foundation-easycla · 2024-09-05T11:32:45Z

The committers listed above are authorized under a signed CLA.

✅ login: pramodbindal / name: Pramod Bindal (199461a, f913a15, 5fe3138, 9f35d61, 603be3f, 11b34dc, 7f58fba)

tekton-robot · 2024-09-05T11:32:51Z

Hi @pramodbindal. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2024-09-05T11:45:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	85.4%	85.8%	0.4

pramodbindal · 2024-09-10T09:31:59Z

++ @vdemeester - please have a look

khrm · 2024-09-12T06:10:37Z

pkg/pipelinerunmetrics/metrics.go

@@ -213,6 +213,7 @@ func viewRegister(cfg *config.Metrics) error {
 		Description: runningPRs.Description(),
 		Measure:     runningPRs,
 		Aggregation: view.LastValue(),
+		TagKeys:     append([]tag.Key{namespaceTag}, prunTag...),


This should be configurable based on some key in config map.

I believe we should always add the namespace tag.
currently prunTag is being used at two places and both with namespaces. what about adding the namespace in pruntag only ?

Please see this issue: #3171

knative/pkg#2931

khrm

/ok-to-test

khrm · 2024-09-12T06:12:42Z

Check this PR: https://github.com/tektoncd/pipeline/pull/7060/files

tekton-robot · 2024-09-12T06:24:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	85.4%	85.8%	0.4

pramodbindal · 2024-09-12T06:42:26Z

/test pull-tekton-pipeline-go-coverage

khrm · 2024-09-12T06:49:08Z

/kind feature

khrm · 2024-09-12T06:49:25Z

/test check-pr-has-kind-label

tekton-robot · 2024-09-12T06:49:28Z

@khrm: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-beta-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests
/test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

/test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2024-09-12T06:52:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	85.4%	85.8%	0.4

tekton-robot · 2024-09-12T06:55:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	85.4%	85.8%	0.4

tekton-robot · 2024-09-12T06:56:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	85.4%	85.8%	0.4

khrm · 2024-09-12T08:31:07Z

/test pull-tekton-pipeline-go-coverage-df

tekton-robot · 2024-09-12T08:31:09Z

@khrm: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-beta-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests
/test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

/test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2024-09-12T08:45:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	85.4%	85.8%	0.4

pramodbindal · 2024-09-16T09:06:29Z

/test all

tekton-robot · 2024-09-16T09:15:53Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/metrics.go	76.2%	73.9%	-2.3
pkg/pipelinerunmetrics/metrics.go	85.4%	83.7%	-1.7

tekton-robot · 2024-09-17T09:33:06Z

@vdemeester: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-beta-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests
/test pull-tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

/test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vdemeester · 2024-09-17T09:33:07Z

/test pull-tekton-pipeline-go-coverage

tekton-robot · 2024-09-17T09:44:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/metrics.go	76.2%	78.3%	2.1
pkg/pipelinerunmetrics/metrics.go	85.4%	83.7%	-1.7

tekton-robot · 2024-09-17T09:47:04Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/metrics.go	76.2%	78.3%	2.1
pkg/pipelinerunmetrics/metrics.go	85.4%	83.7%	-1.7

tekton-robot · 2024-09-17T09:48:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/metrics.go	76.2%	78.3%	2.1
pkg/pipelinerunmetrics/metrics.go	85.4%	83.7%	-1.7

vdemeester · 2024-09-18T12:13:40Z

/retest

pramodbindal · 2024-09-18T12:15:14Z

/test pull-tekton-pipeline-alpha-integration-tests

khrm · 2024-09-19T00:43:25Z

/test pull-tekton-pipeline-alpha-integration-tests

khrm · 2024-09-19T01:31:07Z

Please squash all commits and rebase with the latest changes in the main.

pramodbindal · 2024-09-19T02:29:59Z

/retest

pramodbindal · 2024-09-19T04:39:45Z

/retest

tekton-robot · 2024-09-19T04:43:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	85.4%	85.8%	0.4

tekton-robot · 2024-09-19T05:01:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	85.4%	85.8%	0.4

tekton-robot · 2024-09-19T05:01:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	85.4%	85.8%	0.4

tekton-robot · 2024-09-19T05:07:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/metrics.go	85.4%	85.8%	0.4

tekton-robot · 2024-09-19T05:32:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2024-09-19T05:36:24Z

@pramodbindal: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-pipeline-alpha-integration-tests	`0649270`	link	true	`/test pull-tekton-pipeline-alpha-integration-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 5, 2024

tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2024

tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 5, 2024

tekton-robot requested review from abayer and jerop September 5, 2024 11:32

khrm reviewed Sep 12, 2024

View reviewed changes

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2024

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 12, 2024

tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2024

tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024

pramodbindal force-pushed the SRVKP-6184 branch from e18796f to 9f79bc0 Compare September 19, 2024 04:33

tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2024

pramodbindal force-pushed the SRVKP-6184 branch from 9f79bc0 to 11b34dc Compare September 19, 2024 04:51

pramodbindal closed this Sep 19, 2024

pramodbindal force-pushed the SRVKP-6184 branch from 11b34dc to 0649270 Compare September 19, 2024 05:32

tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 19, 2024

SRVKP-6184 - Add Running PipelineRuns metric for Pipeline and Namespace. #8242

SRVKP-6184 - Add Running PipelineRuns metric for Pipeline and Namespace. #8242

Conversation

pramodbindal commented Sep 5, 2024 • edited Loading

Changes

Submitter Checklist

Release Notes

linux-foundation-easycla bot commented Sep 5, 2024 • edited Loading

tekton-robot commented Sep 5, 2024

tekton-robot commented Sep 5, 2024

pramodbindal commented Sep 10, 2024

khrm Sep 12, 2024

Choose a reason for hiding this comment

pramodbindal Sep 12, 2024

Choose a reason for hiding this comment

khrm Sep 13, 2024

Choose a reason for hiding this comment

khrm Sep 13, 2024

Choose a reason for hiding this comment

khrm left a comment

Choose a reason for hiding this comment

khrm commented Sep 12, 2024

tekton-robot commented Sep 12, 2024

pramodbindal commented Sep 12, 2024

khrm commented Sep 12, 2024

khrm commented Sep 12, 2024

tekton-robot commented Sep 12, 2024

tekton-robot commented Sep 12, 2024

tekton-robot commented Sep 12, 2024

tekton-robot commented Sep 12, 2024

khrm commented Sep 12, 2024

tekton-robot commented Sep 12, 2024

tekton-robot commented Sep 12, 2024

pramodbindal commented Sep 16, 2024

tekton-robot commented Sep 16, 2024

tekton-robot commented Sep 17, 2024

vdemeester commented Sep 17, 2024

tekton-robot commented Sep 17, 2024

tekton-robot commented Sep 17, 2024

tekton-robot commented Sep 17, 2024

vdemeester commented Sep 18, 2024

pramodbindal commented Sep 18, 2024

khrm commented Sep 19, 2024

khrm commented Sep 19, 2024

pramodbindal commented Sep 19, 2024

pramodbindal commented Sep 19, 2024

tekton-robot commented Sep 19, 2024

tekton-robot commented Sep 19, 2024

tekton-robot commented Sep 19, 2024

tekton-robot commented Sep 19, 2024

tekton-robot commented Sep 19, 2024

tekton-robot commented Sep 19, 2024 • edited Loading

pramodbindal commented Sep 5, 2024 •

edited

Loading

linux-foundation-easycla bot commented Sep 5, 2024 •

edited

Loading

tekton-robot commented Sep 19, 2024 •

edited

Loading