Skip to content

Update kubernetes version of the CI #8758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vdemeester
Copy link
Member

Changes

We are lagging a bit behind in terms of kubernetes version we test
against. This updates to run on more "recent" versions of k8s.

@tektoncd/core-maintainers I am not sure what version we should use there, but… right
now we test 1.28.x and 1.29.x, but most recent version of kubernetes
is 1.33.x. We should definitely keep the version we specify in
MIN_KUBERNETES_VERSION in our tests, but I wonder if we should run
all version from it to the latest (which would be 6 k8s version,
making 18 e2e runs).

/kind misc

Signed-off-by: Vincent Demeester vincent@sbr.pm

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels May 12, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from vdemeester after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from abayer and jerop May 12, 2025 09:41
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 12, 2025
@vdemeester
Copy link
Member Author

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 12, 2025
@vdemeester vdemeester force-pushed the more-k8s-versions branch from ef8b5a4 to 7f63613 Compare May 12, 2025 09:47
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2025
@vdemeester vdemeester force-pushed the more-k8s-versions branch from 7f63613 to dd9bd13 Compare May 12, 2025 09:53
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 12, 2025
@afrittoli
Copy link
Member

In terms of how many k8s versions we need to test, I guess it depends on what kind of impact it has in terms of running CI (do we get that many VMs available right away?) and stability - if there are flacky tests getting all tests to pass would become difficult.... if neither is an issue we could test all supported versions.

@afrittoli
Copy link
Member

The oldest test is broken:

ERROR: timeout waiting for pods to come up
tekton-events-controller-8655577f85-g8kzd      0/1   CrashLoopBackOff   5 (2m8s ago)   5m8s
tekton-pipelines-controller-745d695898-9gt2z   0/1   CrashLoopBackOff   5 (107s ago)   5m8s
tekton-pipelines-webhook-97956b68b-nwlk4       0/1   CrashLoopBackOff   5 (2m9s ago)   5m8s
ERROR: Tekton Pipeline did not come up

@vdemeester vdemeester force-pushed the more-k8s-versions branch from dd9bd13 to 33da6e5 Compare May 13, 2025 04:38
We are lagging a bit behind in terms of kubernetes version we test
against. This updates to run on more "recent" versions of Kubernetes.

This also removes some old, unsupported version of Kubernetes from
`setup-kind.sh`.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester vdemeester force-pushed the more-k8s-versions branch from 33da6e5 to e8656e5 Compare May 13, 2025 05:25
@waveywaves
Copy link
Member

waveywaves commented May 13, 2025

Why are we not testing against the new 1.33? Do we have a latest minus 1 policy? for release and testing ?

@vdemeester
Copy link
Member Author

I restarted them a couple of times (~7 or 8?). They all start quickly.. it shows a bit more flakiness (because there is 15 runs now)

@vdemeester
Copy link
Member Author

Why are we not testing against the new 1.33? Do we have a latest minus 1 policy? for release and testing ?

The image weren’t working (I need to check the version of kind that gets installed). But ideally we would 😇

@vdemeester
Copy link
Member Author

So quick recap @afrittoli @waveywaves

  • We could enable 1.33.x as well
  • It doesn't slow down the CI as they all start almost at the same time
  • It's a bit more flaky but not that much (it's "normal" that running 3/4 times more will run into more flakes.. which could be good)

I don't think we want to run all version with stable/beta/alpha though. What we could do is

  • oldest + stable,beta,alpha
  • all between oldest and n-1 with just stable
  • n-1 + stable, beta, alpha
  • latest + stable,beta,alpha

It might be a bit tricky for the required checks as these will be dynamic. We should probably write a small tool that updates the plumbing prow required configuration based on the workflow configuration (it is definitely doable, should be relatively easy).

The other thing I would like to look into is to be able to start some on demand, like I want 1.29 with alpha, it's not in the default run but I want to be able to do /run … and it runs. I need to look into this for GH workflows.

@waveywaves
Copy link
Member

/retest

@vdemeester
Copy link
Member Author

The k8s-plus-one checks cannot be re-run, they do not exists. This is related to the "require checks" question I had

It might be a bit tricky for the required checks as these will be dynamic. We should probably write a small tool that updates the plumbing prow required configuration based on the workflow configuration (it is definitely doable, should be relatively easy).

@twoGiants
Copy link
Member

twoGiants commented May 23, 2025

  • We could enable 1.33.x as well

Then 1.28.x could be dropped.

I don't think we want to run all version with stable/beta/alpha though. What we could do is...

Agree, looks good.

The other thing I would like to look into is to be able to start some on demand, like I want 1.29 with alpha, it's not in the default run but I want to be able to do /run … and it runs. I need to look into this for GH workflows.

Is there demand for it?

If it is not affecting CI stability anyway then maybe it's easier to just add them to the matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/misc Categorizes issue or PR as a miscellaneuous one. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants