-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Update kubernetes version of the CI #8758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
ef8b5a4
to
7f63613
Compare
7f63613
to
dd9bd13
Compare
In terms of how many k8s versions we need to test, I guess it depends on what kind of impact it has in terms of running CI (do we get that many VMs available right away?) and stability - if there are flacky tests getting all tests to pass would become difficult.... if neither is an issue we could test all supported versions. |
The
|
dd9bd13
to
33da6e5
Compare
We are lagging a bit behind in terms of kubernetes version we test against. This updates to run on more "recent" versions of Kubernetes. This also removes some old, unsupported version of Kubernetes from `setup-kind.sh`. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
33da6e5
to
e8656e5
Compare
Why are we not testing against the new 1.33? Do we have a latest minus 1 policy? for release and testing ? |
I restarted them a couple of times (~7 or 8?). They all start quickly.. it shows a bit more flakiness (because there is 15 runs now) |
The image weren’t working (I need to check the version of kind that gets installed). But ideally we would 😇 |
So quick recap @afrittoli @waveywaves
I don't think we want to run all version with stable/beta/alpha though. What we could do is
It might be a bit tricky for the required checks as these will be dynamic. We should probably write a small tool that updates the plumbing prow required configuration based on the workflow configuration (it is definitely doable, should be relatively easy). The other thing I would like to look into is to be able to start some on demand, like I want 1.29 with alpha, it's not in the default run but I want to be able to do |
/retest |
The
|
Then
Agree, looks good.
Is there demand for it? If it is not affecting CI stability anyway then maybe it's easier to just add them to the matrix. |
Changes
We are lagging a bit behind in terms of kubernetes version we test
against. This updates to run on more "recent" versions of k8s.
@tektoncd/core-maintainers I am not sure what version we should use there, but… right
now we test 1.28.x and 1.29.x, but most recent version of kubernetes
is 1.33.x. We should definitely keep the version we specify in
MIN_KUBERNETES_VERSION
in our tests, but I wonder if we should runall version from it to the latest (which would be 6 k8s version,
making 18 e2e runs).
/kind misc
Signed-off-by: Vincent Demeester vincent@sbr.pm
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes