Move Step
Validate and ValidateError tests to container_validation_test.go
.
#8778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Now that
Step
implements theValidatable
interface the tests for theStep
validation are moved fromtask_validation_test.go
tocontainer_validation_test.go
.The tests cases which test for a valid Step and for validation errors were extracted from
task_validation_test.go
:TestTaskSpecValidate
TestTaskSpecValidateError
and moved to new test functions in
container_validation_test.go
:TestStepValidate
TestStepValidateError
This PR is one of a series to migrate the tests in small batches so that they are easier to review.
More details are in issue #8700.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes