Skip to content

Move Step Validate and ValidateError tests to container_validation_test.go. #8778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twoGiants
Copy link
Member

@twoGiants twoGiants commented May 15, 2025

Changes

Now that Step implements the Validatable interface the tests for the Step validation are moved from task_validation_test.go to container_validation_test.go.

The tests cases which test for a valid Step and for validation errors were extracted from task_validation_test.go:

  • TestTaskSpecValidate
  • TestTaskSpecValidateError

and moved to new test functions in container_validation_test.go:

  • TestStepValidate
  • TestStepValidateError

This PR is one of a series to migrate the tests in small batches so that they are easier to review.

More details are in issue #8700.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. labels May 15, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign pritidesai after the PR has been reviewed.
You can assign the PR to them by writing /assign @pritidesai in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from dibyom and vdemeester May 15, 2025 13:25
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2025
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/task_validation.go 99.1% 99.1% 0.0

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2025
Now that `Step` implements the `Validatable` interface the tests for the
`Step` validation are moved from `task_validation_test.go` to
`container_validation_test.go`.

The tests cases which test for a valid Step and for validation errors
were extracted from `task_validation_test.go`:

- `TestTaskSpecValidate`
- `TestTaskSpecValidateError`

and moved to new test functions in `container_validation_test.go`:

- `TestStepValidate`
- `TestStepValidateError`

Issue tektoncd#8700.

Signed-off-by: Stanislav Jakuschevskij <stas@two-giants.com>
@twoGiants twoGiants changed the title 🚧 Move Step Validate and ValidateError tests to container_validation_test.go. 🚧 Move Step Validate and ValidateError tests to container_validation_test.go. May 22, 2025
@twoGiants twoGiants force-pushed the issue-8700-move-step-validate-and-validate-error-tests branch from 337336c to e6cad38 Compare May 22, 2025 11:11
@twoGiants twoGiants marked this pull request as ready for review May 22, 2025 11:11
@tekton-robot tekton-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 22, 2025
@tekton-robot tekton-robot requested review from abayer and pritidesai May 22, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants