Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badge to README for integration tests #96

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

bobcatfish
Copy link
Collaborator

Integration tests were added as part of #16

Upside: another badge!
Downside: badge doesn't look good at all XD

image

Looks like we're still hitting kubernetes/test-infra#9628 so if anyone is looking for a break from build-pipeline that would be super helpful to fix XD

Integration tests were added as part of #16
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2018
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2018
@nader-ziada
Copy link
Member

Do you want to add the badge anyways? Or wait for it to be fixed in test-infra?

@bobcatfish
Copy link
Collaborator Author

Do you want to add the badge anyways? Or wait for it to be fixed in test-infra?

I could go either way - right now I'm leaning toward adding it anyway, since this issue can effect either of the current badges we have already, but if you lean the other way I'm happy to wait for a fix! and/or try to fix it :)

@nader-ziada
Copy link
Member

We can add the badge first, then figure out how to make it green
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2018
@knative-prow-robot knative-prow-robot merged commit 29d25e5 into tektoncd:master Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants