Fix ingress annotation and cert-manager configuration 👼 #152
Conversation
tekton-robot
added
the
size/XS
| @@ -7,8 +7,8 @@ spec: | |||
| email: dlorenc@google.com | |||
| privateKeySecretRef: | |||
| name: letsencrypt-prod | |||
| server: https://acme-staging-v02.api.letsencrypt.org/directory | |||
There was a problem hiding this comment.
This was problematic as the generated cert was fake
prow/ingress.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: extensions/v1beta1 | |||
| kind: Ingress | |||
| metadata: | |||
| annotations: | |||
| cert-manager.io/acme-http01-edit-in-place: "true" | |||
| acme.cert-manager.io/acme-http01-edit-in-place: "true" | |||
There was a problem hiding this comment.
This was blocking the actual cert generation as cert-manager was trying to create an additionnal ingress and thus, the HTTP challenge was always 404
There was a problem hiding this comment.
I think this should be acme.cert-manager.io/http01-edit-in-place: "true" ?
https://cert-manager.io/docs/tutorials/acme/ingress/
There was a problem hiding this comment.
yes.. I forgot to push my last change 😂
|
I think it really fixed it 👼 /cc @bobcatfish @dibyom |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
prow/ingress.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: extensions/v1beta1 | |||
| kind: Ingress | |||
| metadata: | |||
| annotations: | |||
| cert-manager.io/acme-http01-edit-in-place: "true" | |||
| acme.cert-manager.io/acme-http01-edit-in-place: "true" | |||
There was a problem hiding this comment.
I think this should be acme.cert-manager.io/http01-edit-in-place: "true" ?
https://cert-manager.io/docs/tutorials/acme/ingress/
This is what was required (with some crazy, not useful hack on my part 😹) to fix https on prow.tekton.dev Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
fix-ingress-cert-manager
branch
from
6e7eb30
to
d45887d
Compare
tekton-robot
added
the
approved
|
/lgtm Whoops! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This is what was required (with some crazy, not useful hack on my part
😹) to fix https on prow.tekton.dev
As follow-up, we need a little bit more docs/link to help debug potential problems 👼
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.