Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix param order in koparse backwards_compatible_params #2196

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

AlanGreene
Copy link
Member

@AlanGreene AlanGreene commented Sep 19, 2024

Changes

See for example: https://dashboard.dogfooding.tekton.dev/#/namespaces/tekton-nightly/pipelineruns/wait-task-release-nightly-qk72w?pipelineTask=publish-images&step=koparse

2024-09-19T09:14:57.305509466Z + IMAGES_PATH=[gcr.io/tekton-nightly/github.com/tektoncd/experimental](http://gcr.io/tekton-nightly/github.com/tektoncd/experimental)
2024-09-19T09:14:57.305584903Z + '[' wait-task '!='  ]
2024-09-19T09:14:57.307406787Z + IMAGES_PATH=[gcr.io/tekton-nightly/github.com/tektoncd/experimental/wait-task](http://gcr.io/tekton-nightly/github.com/tektoncd/experimental/wait-task)
2024-09-19T09:14:57.307428664Z + [IMAGES=gcr.io/tekton-nightly/github.com/tektoncd/experimental/wait-task/cmd/controller:v20240919-2ce2f72e49](http://images=gcr.io/tekton-nightly/github.com/tektoncd/experimental/wait-task/cmd/controller:v20240919-2ce2f72e49)
2024-09-19T09:14:57.307563297Z + koparse --path /workspace/output/v20240919-2ce2f72e49/release.yaml --base [gcr.io/tekton-nightly/github.com/tektoncd/experimental/wait-task](http://gcr.io/tekton-nightly/github.com/tektoncd/experimental/wait-task) --images [gcr.io/tekton-nightly/github.com/tektoncd/experimental/wait-task/cmd/controller:v20240919-2ce2f72e49](http://gcr.io/tekton-nightly/github.com/tektoncd/experimental/wait-task/cmd/controller:v20240919-2ce2f72e49)
2024-09-19T09:14:59.511998655Z Traceback (most recent call last):
2024-09-19T09:14:59.512055747Z   File "/usr/local/bin/koparse", line 142, in <module>
2024-09-19T09:14:59.512668819Z     container_registry, expected_images, base = backwards_compatible_params(
2024-09-19T09:14:59.512690946Z                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-09-19T09:14:59.512697022Z   File "/usr/local/bin/koparse", line 120, in backwards_compatible_params
2024-09-19T09:14:59.512943282Z     container_registry = "/".join(base.split("/")[:2])
2024-09-19T09:14:59.512956609Z                                   ^^^^^^^^^^
2024-09-19T09:14:59.513050417Z AttributeError: 'list' object has no attribute 'split'

/kind bug

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 19, 2024
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2024
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2024
@tekton-robot tekton-robot merged commit 1c3aa3e into tektoncd:main Sep 23, 2024
5 checks passed
@AlanGreene AlanGreene deleted the koparse branch September 23, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants