Add combine script, to combine two manifest lists and push the result #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
size/XXL
wlynch
reviewed
Aug 3, 2021
This will be used to build a combined base image from our current distroless/static base image, and a Windows base image, to produce a base image that supports both. This will, in turn, provide a base image for Tekton images so they can be built with multi-OS support, in addition to their existing multi-arch(-but-only-Linux) support today.
|
/lgtm |
tekton-robot
added
lgtm
|
/test plumbing-yamllint |
1 similar comment
|
/test plumbing-yamllint |
|
Don't mind me, just trying something out: /run try-out-tekton |
|
hahaha well that sure didnt work - sorry for the noise @imjasonh ... now im not sure how to remove that check 😅 |
|
I forced it to be successful 🙏 sorry again for the noise |
bobcatfish
added a commit
to bobcatfish/plumbing
that referenced
this pull request
Aug 9, 2021
Two years ago I was playing around with Prow's tekton support as a way to dogfood pipelines and I created this config to run a hello world type pipeline on the plumbing repo (tektoncd#66). Today while looking for uses of PipelineResources to update to use the experimental Pipeline to TaskRun custom task instead, I found this. It no longer runs successfully (just added noise to tektoncd#871) and I don't think there's any reason to keep it around.
2 tasks
bobcatfish
added a commit
to bobcatfish/plumbing
that referenced
this pull request
Aug 9, 2021
Two years ago I was playing around with Prow's tekton support as a way to dogfood pipelines and I created this config to run a hello world type pipeline on the plumbing repo (tektoncd#66). Today while looking for uses of PipelineResources to update to use the experimental Pipeline to TaskRun custom task instead, I found this. It no longer runs successfully (just added noise to tektoncd#871) and I don't think there's any reason to keep it around.
|
/test plumbing-yamllint |
|
One more try to bump the yamllint task: /test plumbing-yamllint |
|
/approve |
|
/approve cancel |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test plumbing-yamllint |
|
dropping lgtm to unblock tide /lgtm cancel |
tekton-robot
pushed a commit
that referenced
this pull request
Aug 10, 2021
Two years ago I was playing around with Prow's tekton support as a way to dogfood pipelines and I created this config to run a hello world type pipeline on the plumbing repo (#66). Today while looking for uses of PipelineResources to update to use the experimental Pipeline to TaskRun custom task instead, I found this. It no longer runs successfully (just added noise to #871) and I don't think there's any reason to keep it around.
|
re-lgtming now that tide is unblocked and plumbing-yamllint has passed /lgtm |
|
/test plumbing-yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This will be used to build a combined base image from our current
distroless/static base image, and a Windows base image, to produce a
base image that supports both.
This will, in turn, provide a base image for Tekton images so they can
be built with multi-OS support, in addition to their existing
multi-arch(-but-only-Linux) support today.
Ref tektoncd/pipeline#182
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
/kind feature