Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watcher: Pipeline resource cleanup #59

Closed
wlynch opened this issue Jan 21, 2021 · 2 comments · Fixed by #103
Closed

Watcher: Pipeline resource cleanup #59

wlynch opened this issue Jan 21, 2021 · 2 comments · Fixed by #103
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@wlynch
Copy link
Member

wlynch commented Jan 21, 2021

Feature request

After a TaskRun/PipelineRun is completed and successfully uploaded, we should delete the etcd based data to free up resources on the user's cluster.

Requirements:

  • etcd based data should not be deleted until the Task/PipelineRun is complete and we've confirmed that the data has been successfully uploaded to the API.
  • There should be a configurable grace period for how long we wait before we deleting so that other integrations relying on the CRD API directly don't break.
  • Cleanup behavior / grace period should be flag/configmap gated

Use case

Task/PipelineRun clean up has been a much requested feature, but is at odds with results storage since once the CRD object is gone from etcd, the results are gone with it.

Making this a feature of the Results watcher means that we can ensure that this clean up happens after results have been stored durably.

See:

@wlynch wlynch added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 21, 2021
@wlynch wlynch changed the title Watcher: Pipeline etcd cleanup Watcher: Pipeline resource cleanup Jan 21, 2021
@tekton-robot
Copy link

@XinruZhang: GitHub didn't allow me to assign the following users: me.

Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign me

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@XinruZhang
Copy link
Member

/assign xinruzhang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants