Add Support for Tekton Pipeline v1 APIs #352

khrm · 2023-02-14T13:46:17Z

No description provided.

khrm

/kind feature

khrm

/hold

vdemeester · 2023-02-14T13:58:46Z

So I think results is in a similar case as chains, see tektoncd/chains#665 (comment). Today results will work with tektoncd/pipeline release >= 0.43, as it will get object through the v1beta1 API (and conversion webhook do the work for us).

This PR would make results require a tektoncd/pipeline release that supports v1 ; so it would not work with any release prior to v0.43. Seems fine to me, but we need to make sure we are ok with this, that starting from the next release of tektoncd/results, the minimum version of a tektoncd/pipeline release is going to be 0.43.

adambkaplan · 2023-02-17T14:27:11Z

Per WG discussion - we are going to hold this PR until v0.5.0 is released, then we can cut over to v1.

See #303 (comment)

adambkaplan · 2023-03-23T16:47:58Z

Keeping the hold on this PR - the logs feature is likely blocked by tektoncd/cli#1837

khrm · 2023-03-30T12:35:50Z

A new version of cli with v1 has been released. I would rebase and update with cli.

Add support for storing objects in v1 CR.

khrm · 2023-04-19T17:03:59Z

/hold cancel

khrm · 2023-04-19T17:15:36Z

@alan-ghelardi @dibyom @adambkaplan @sayan-biswas @enarha We should try to get this merge asap.

vdemeester · 2023-04-19T17:31:09Z

/approve

tekton-robot · 2023-04-19T17:31:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

adambkaplan

Most of the code upgrades look good.

I do have a few questions regarding upgrade scenarios:

Can the apiserver handle updates from v1beta1 and v1 objects (ex - rolling upgrade of watchers)
Do we record the object version in the underlying record? Will clients be able to decode v1beta1 and v1 objects?

adambkaplan · 2023-04-19T18:31:30Z

tools/tkn-results/tkn-results

This file should not be added. Please remove and add a .gitignore entry.

adambkaplan · 2023-04-19T18:33:06Z

tools/tkn-results/go.mod

It looks like we have a few obsolete dependencies as well. Maybe we take this up in separate pull requests?

adambkaplan · 2023-04-19T18:33:50Z

tools/simpleui/main.go

@@ -68,7 +68,7 @@ type ui struct {
 }

 func main() {
-	conn, err := grpc.Dial("localhost:8080", grpc.WithInsecure(), grpc.WithBlock())
+	conn, err := grpc.Dial("localhost:50051", grpc.WithInsecure(), grpc.WithBlock())


Why change the port number?

I think this was changed in a different pr. So will update this. It happened due to rebasing.

adambkaplan · 2023-04-19T18:37:34Z

pkg/api/server/v1alpha2/record/record.go

-		return json.Unmarshal(m.GetValue(), &v1beta1.TaskRun{})
+		return json.Unmarshal(m.GetValue(), &v1.TaskRun{})


Will this break if the value data contains v1beta1.TaskRun?

adambkaplan · 2023-04-19T18:38:08Z

pkg/api/server/v1alpha2/record/record.go

 	case "pipeline.tekton.dev/PipelineRun":
-		return json.Unmarshal(m.GetValue(), &v1beta1.PipelineRun{})
+		return json.Unmarshal(m.GetValue(), &v1.PipelineRun{})


Will this break if the value data contains v1beta1.PipelineRun?

adambkaplan · 2023-04-19T18:47:53Z

pkg/watcher/reconciler/pipelinerun/reconciler.go

-	} else {
-		// TODO(alan-ghelardi): remove this else once we support only
-		// Tekton v1 API since the full embedded status will no longer
-		// be supported.


+1 - great work @alan-ghelardi to mark this out ahead of time!

adambkaplan · 2023-04-19T18:49:30Z

pkg/watcher/reconciler/reconciler_test.go

Please remove this file. It was the source of a data race condition in our tests. We have replaced this "integration" controller test with a full end to end test.

adambkaplan · 2023-04-19T18:54:38Z

tools/postgres-migrate/main.go

Changes to posgres-migrate are probably not necessary. This is a legacy tool from when this project used MySQL.

adambkaplan · 2023-04-19T18:55:05Z

tools/postgres-migrate/main_test.go

Changes to postgres-migrate are probably not necessary.

adambkaplan · 2023-04-19T18:55:29Z

tools/postgres-migrate/testdata_test.go

Changes to postgres-migrate are probably not necessary

adambkaplan · 2023-04-19T19:00:27Z

/hold

At the last working group meeting, @enarha wanted to take the lead on publishing a new release this week. We should wait on merging this change until that is complete.

tekton-robot · 2023-05-09T15:32:56Z

@khrm: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2023-08-07T16:13:07Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot · 2023-09-06T16:18:13Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot · 2023-10-06T16:21:38Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot · 2023-10-06T16:21:41Z

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

khrm · 2023-10-06T17:03:02Z

We need to create an implementation based on WG call discussions and TEP in the community.

tekton-robot requested review from alan-ghelardi and dibyom February 14, 2023 13:46

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 14, 2023

khrm commented Feb 14, 2023

View reviewed changes

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 14, 2023

khrm commented Feb 14, 2023

View reviewed changes

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2023

khrm force-pushed the f/mig2v1 branch 3 times, most recently from 2480316 to e71de6b Compare February 14, 2023 17:35

khrm mentioned this pull request Feb 16, 2023

Bump github.com/tektoncd/pipeline from 0.39.0 to 0.44.0 #329

Closed

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2023

khrm force-pushed the f/mig2v1 branch from e71de6b to d4bfd0e Compare April 19, 2023 15:23

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2023

khrm force-pushed the f/mig2v1 branch 2 times, most recently from 31b2f5a to f91c812 Compare April 19, 2023 15:59

khrm added 2 commits April 19, 2023 22:30

Add Support for Tekton Pipeline v1 APIs

54cd72f

Add support for storing objects in v1 CR.

Update cli to v0.30.1

79ab63e

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023

khrm force-pushed the f/mig2v1 branch from f91c812 to 79ab63e Compare April 19, 2023 17:04

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023

adambkaplan reviewed Apr 19, 2023

View reviewed changes

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2023

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2023

khrm mentioned this pull request Jul 13, 2023

v1 Release of Results #526

Open

5 tasks

sayan-biswas mentioned this pull request Jul 25, 2023

Fix pipeline webhook validation error openshift-pipelines/tektoncd-results#46

Merged

8 tasks

tekton-robot added the lifecycle/stale label Aug 7, 2023

tekton-robot added lifecycle/rotten and removed lifecycle/stale labels Sep 6, 2023

tekton-robot closed this Oct 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Support for Tekton Pipeline v1 APIs #352

Add Support for Tekton Pipeline v1 APIs #352

khrm commented Feb 14, 2023

khrm left a comment

khrm left a comment

vdemeester commented Feb 14, 2023

adambkaplan commented Feb 17, 2023

adambkaplan commented Mar 23, 2023

khrm commented Mar 30, 2023

khrm commented Apr 19, 2023

khrm commented Apr 19, 2023

vdemeester commented Apr 19, 2023

tekton-robot commented Apr 19, 2023

adambkaplan left a comment

adambkaplan Apr 19, 2023

adambkaplan Apr 19, 2023

adambkaplan Apr 19, 2023

khrm Apr 19, 2023

adambkaplan Apr 19, 2023

adambkaplan Apr 19, 2023

adambkaplan Apr 19, 2023

adambkaplan Apr 19, 2023

adambkaplan Apr 19, 2023

adambkaplan Apr 19, 2023

adambkaplan Apr 19, 2023

adambkaplan commented Apr 19, 2023

tekton-robot commented May 9, 2023

tekton-robot commented Aug 7, 2023

tekton-robot commented Sep 6, 2023

tekton-robot commented Oct 6, 2023

tekton-robot commented Oct 6, 2023

khrm commented Oct 6, 2023

		return json.Unmarshal(m.GetValue(), &v1beta1.TaskRun{})
		return json.Unmarshal(m.GetValue(), &v1.TaskRun{})

Add Support for Tekton Pipeline v1 APIs #352

Add Support for Tekton Pipeline v1 APIs #352

Conversation

khrm commented Feb 14, 2023

khrm left a comment

Choose a reason for hiding this comment

khrm left a comment

Choose a reason for hiding this comment

vdemeester commented Feb 14, 2023

adambkaplan commented Feb 17, 2023

adambkaplan commented Mar 23, 2023

khrm commented Mar 30, 2023

khrm commented Apr 19, 2023

khrm commented Apr 19, 2023

vdemeester commented Apr 19, 2023

tekton-robot commented Apr 19, 2023

adambkaplan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adambkaplan commented Apr 19, 2023

tekton-robot commented May 9, 2023

tekton-robot commented Aug 7, 2023

tekton-robot commented Sep 6, 2023

tekton-robot commented Oct 6, 2023

tekton-robot commented Oct 6, 2023

khrm commented Oct 6, 2023