Skip to content

Commit

Permalink
Refactor to not use logger from pipeline
Browse files Browse the repository at this point in the history
This is a refactoring to not use logger from
tektoncd/pipeline as it can be directly used from
knative.dev/pkg and also it has been from the
pipeline repo tektoncd/pipeline#3058
so whever there is a dependency bump it needs to
be done.
  • Loading branch information
piyush-garg authored and tekton-robot committed Sep 18, 2020
1 parent 2cc62a2 commit 8cef2e8
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 53 deletions.
3 changes: 1 addition & 2 deletions pkg/interceptors/bitbucket/bitbucket_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,11 @@ import (
"testing"

"github.com/google/go-cmp/cmp"

"github.com/tektoncd/pipeline/pkg/logging"
triggersv1 "github.com/tektoncd/triggers/pkg/apis/triggers/v1alpha1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
fakekubeclient "knative.dev/pkg/client/injection/kube/client/fake"
"knative.dev/pkg/logging"
rtesting "knative.dev/pkg/reconciler/testing"
)

Expand Down
5 changes: 2 additions & 3 deletions pkg/interceptors/cel/cel_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,12 @@ import (
"github.com/google/cel-go/common/types"
"github.com/google/cel-go/common/types/ref"
"github.com/google/go-cmp/cmp"
"github.com/tektoncd/pipeline/pkg/logging"
triggersv1 "github.com/tektoncd/triggers/pkg/apis/triggers/v1alpha1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
fakekubeclient "knative.dev/pkg/client/injection/kube/client/fake"
"knative.dev/pkg/logging"
rtesting "knative.dev/pkg/reconciler/testing"

triggersv1 "github.com/tektoncd/triggers/pkg/apis/triggers/v1alpha1"
)

const testNS = "testing-ns"
Expand Down
3 changes: 1 addition & 2 deletions pkg/interceptors/github/github_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,11 @@ import (
"testing"

"github.com/google/go-cmp/cmp"

"github.com/tektoncd/pipeline/pkg/logging"
triggersv1 "github.com/tektoncd/triggers/pkg/apis/triggers/v1alpha1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
fakekubeclient "knative.dev/pkg/client/injection/kube/client/fake"
"knative.dev/pkg/logging"
rtesting "knative.dev/pkg/reconciler/testing"
)

Expand Down
3 changes: 1 addition & 2 deletions pkg/interceptors/gitlab/gitlab_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,11 @@ import (
"testing"

"github.com/google/go-cmp/cmp"

"github.com/tektoncd/pipeline/pkg/logging"
triggersv1 "github.com/tektoncd/triggers/pkg/apis/triggers/v1alpha1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
fakekubeclient "knative.dev/pkg/client/injection/kube/client/fake"
"knative.dev/pkg/logging"
rtesting "knative.dev/pkg/reconciler/testing"
)

Expand Down
43 changes: 0 additions & 43 deletions vendor/github.com/tektoncd/pipeline/pkg/logging/config.go

This file was deleted.

1 change: 0 additions & 1 deletion vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ github.com/tektoncd/pipeline/pkg/client/resource/injection/client
github.com/tektoncd/pipeline/pkg/client/resource/injection/client/fake
github.com/tektoncd/pipeline/pkg/contexts
github.com/tektoncd/pipeline/pkg/list
github.com/tektoncd/pipeline/pkg/logging
github.com/tektoncd/pipeline/pkg/names
github.com/tektoncd/pipeline/pkg/reconciler/pipeline/dag
github.com/tektoncd/pipeline/pkg/substitution
Expand Down

0 comments on commit 8cef2e8

Please sign in to comment.