Fix lint errors and update the linter to revive.

golint is deprecated and archived, so golangci-lint recommends updating
to revive. This handles the update and fixes new lint errors.

Signed-off-by: Dan Lorenc <dlorenc@google.com>

.golangci.yml

@@ -15,4 +15,4 @@ linters:
   - goimports
   - gosec
   - gocritic
-  - golint
+  - revive

pkg/reconciler/eventlistener/eventlistener.go

@@ -109,8 +109,7 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, el *v1beta1.EventListene
 	el.SetDefaults(contexts.WithUpgradeViaDefaulting(ctx))
 
 	if el.Spec.Resources.CustomResource != nil {
-		kError := r.reconcileCustomObject(ctx, el)
-		return wrapError(kError, nil)
+		return r.reconcileCustomObject(ctx, el)
 	}
 	deploymentReconcileError := r.reconcileDeployment(ctx, el)
 	serviceReconcileError := r.reconcileService(ctx, el)

test/controller.go

@@ -110,7 +110,7 @@ func init() {
 }
 
 // SeedResources returns Clients populated with the given Resources
-// nolint: golint
+// nolint: revive
 func SeedResources(t *testing.T, ctx context.Context, r Resources) Clients {
 	t.Helper()
 	c := Clients{