Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log for event parameters #195

Closed
vtereso opened this issue Oct 29, 2019 · 1 comment · Fixed by #226
Closed

Add log for event parameters #195

vtereso opened this issue Oct 29, 2019 · 1 comment · Fixed by #226
Assignees
@wlynch
Milestone
Triggers 0.2

Comments

@vtereso
Copy link

vtereso commented Oct 29, 2019

Expected Behavior

The event parameters should be logged after (and maybe before) resolution to help debug any failures.

Actual Behavior

There are no logs.
@ncskier ncskier added this to the Triggers 0.2 milestone Oct 30, 2019
@wlynch
Copy link
Member

wlynch commented Nov 18, 2019

I can handle this.

/assign wlynch

wlynch added a commit to wlynch/triggers that referenced this issue Nov 18, 2019
@wlynch
Refactor template resolution into separate binding and template funcs.
0c09fcb 
* Renames Resolve[d]Binding -> ResolvedTrigger to better reflect its
  purpose.
* Splits NewResources -> ResolveBinding, ResolveTemplate.
* Adds logging of resolved event parameters to sink to resolve tektoncd#195.
* Adds annotated logging to sink to record event and trigger identifiers
  in sink logs.
@wlynch wlynch mentioned this issue Nov 18, 2019
Merged
3 tasks
wlynch added a commit to wlynch/triggers that referenced this issue Nov 18, 2019
@wlynch
Refactor template resolution into separate binding and template funcs.
d6250ee 
* Renames Resolve[d]Binding -> ResolvedTrigger to better reflect its
  purpose.
* Splits NewResources -> ResolveBinding, ResolveTemplate.
* Adds logging of resolved event parameters to sink to resolve tektoncd#195.
* Adds annotated logging to sink to record event and trigger identifiers
  in sink logs.
wlynch added a commit to wlynch/triggers that referenced this issue Nov 19, 2019
@wlynch
Refactor template resolution into separate binding and template funcs.
e730b35 
* Renames Resolve[d]Binding -> ResolvedTrigger to better reflect its
  purpose.
* Splits NewResources -> ResolveBinding, ResolveTemplate.
* Adds logging of resolved event parameters to sink to resolve tektoncd#195.
* Adds annotated logging to sink to record event and trigger identifiers
  in sink logs.
wlynch added a commit to wlynch/triggers that referenced this issue Nov 19, 2019
@wlynch
Refactor template resolution into separate binding and template funcs.
ecf2609 
* Renames Resolve[d]Binding -> ResolvedTrigger to better reflect its
  purpose.
* Splits NewResources -> ResolveBinding, ResolveTemplate.
* Adds logging of resolved event parameters to sink to resolve tektoncd#195.
* Adds annotated logging to sink to record event and trigger identifiers
  in sink logs.
wlynch added a commit to wlynch/triggers that referenced this issue Nov 19, 2019
@wlynch
Refactor template resolution into separate binding and template funcs.
75319c9 
* Renames Resolve[d]Binding -> ResolvedTrigger to better reflect its
  purpose.
* Splits NewResources -> ResolveBinding, ResolveTemplate.
* Adds logging of resolved event parameters to sink to resolve tektoncd#195.
* Adds annotated logging to sink to record event and trigger identifiers
  in sink logs.
wlynch added a commit to wlynch/triggers that referenced this issue Nov 19, 2019
@wlynch
Refactor template resolution into separate binding and template funcs.
b2d763f 
* Renames Resolve[d]Binding -> ResolvedTrigger to better reflect its
  purpose.
* Splits NewResources -> ResolveBinding, ResolveTemplate.
* Adds logging of resolved event parameters to sink to resolve tektoncd#195.
* Adds annotated logging to sink to record event and trigger identifiers
  in sink logs.
tekton-robot pushed a commit that referenced this issue Nov 20, 2019
@wlynch @tekton-robot
Refactor template resolution into separate binding and template funcs.
c039540 
* Renames Resolve[d]Binding -> ResolvedTrigger to better reflect its
  purpose.
* Splits NewResources -> ResolveBinding, ResolveTemplate.
* Adds logging of resolved event parameters to sink to resolve #195.
* Adds annotated logging to sink to record event and trigger identifiers
  in sink logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wlynch wlynch

Labels
None yet
Projects
None yet
Milestone
Triggers 0.2
Development

Successfully merging a pull request may close this issue.

Refactor template resolution into separate binding and template funcs. wlynch/triggers
3 participants
@wlynch @ncskier @vtereso