Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Add URL option to WebhookInterceptor #270

Closed
wlynch opened this issue Dec 11, 2019 · 5 comments · Fixed by #1002
Closed

FR: Add URL option to WebhookInterceptor #270

wlynch opened this issue Dec 11, 2019 · 5 comments · Fixed by #1002
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone

Comments

@wlynch
Copy link
Member

wlynch commented Dec 11, 2019

Expected Behavior

WebhookInteceptor docs say: Either objectRef or url can be specified

Actual Behavior

There is no url field. We should add it!

@dibyom dibyom added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 12, 2019
@dibyom dibyom added this to the Triggers 0.3 milestone Jan 21, 2020
@dibyom dibyom removed this from the Triggers 0.3 milestone Feb 18, 2020
@wlynch
Copy link
Member Author

wlynch commented Feb 21, 2020

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 13, 2020
@dibyom
Copy link
Member

dibyom commented Aug 13, 2020

/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 13, 2020
@dibyom
Copy link
Member

dibyom commented Aug 14, 2020

We should add an URI field just like https://github.com/knative/pkg/blob/master/apis/duck/v1beta1/destination.go#L46
(we could try seeing if we can the Destination struct itself)

@dibyom dibyom added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 14, 2020
@dibyom dibyom modified the milestones: Triggers v0.8.0, Triggers Beta Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants