Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to trigger on kubernetes resouces, not only web hooks #478

Closed
dbazhal opened this issue Mar 13, 2020 · 22 comments
Closed

Add ability to trigger on kubernetes resouces, not only web hooks #478

dbazhal opened this issue Mar 13, 2020 · 22 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@dbazhal
Copy link

dbazhal commented Mar 13, 2020

Expected Behavior

Any way to trigger on some in-cluster event/resource required.
Watch-list objects of some type, or watch kubernetes events, and when an object meets some conditions - then take some infro from it, and trigger as tekton triggers usually do - create object(usually taskrun/pipelinerun).

Actual Behavior

Now we can only trigger on some external http events.

@dibyom
Copy link
Member

dibyom commented Mar 13, 2020

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 13, 2020
@vtereso
Copy link

vtereso commented Mar 24, 2020

I like the idea of this. However, most resources have their own controller so I don't entirely know the use case.

@dbazhal
Copy link
Author

dbazhal commented Mar 24, 2020

I like the idea of this. However, most resources have their own controller so I don't entirely know the use case.

I won't be inventing new ideas, my own goals for example are to:

  • lower automation entry level for my users, so they could do anything even not knowing golang/kubernetes api internals
  • watch apps behaviour and launch self-healing/notification tasks/pipelines
  • watch different objects change and launch pipeline that bakes immutable artifact as compilation of many factors and delivers it through many testing environments to production unchanged

@dbazhal
Copy link
Author

dbazhal commented Mar 30, 2020

Oh, and another reasons came to mind.

  1. kubernetes deployments watch themself and run rollout on change
  2. in okd <= 3.11 there are buildconfigs/deploymentconfigs, and they all can trigger when themselves change

Tekton pipelines and tasks do not run themselves on change, because they are separated from their runs.
So there must be some tool to run tekton pipeline when it changes. Tekton triggers could be such tool.

@wlynch
Copy link
Member

wlynch commented Apr 14, 2020

You might be interested in https://knative.dev/docs/eventing/samples/kubernetes-event-source/ which would allow you to produce events that could then be consumed/filtered by Tekton Triggers.

@dbazhal
Copy link
Author

dbazhal commented Apr 14, 2020

You might be interested in https://knative.dev/docs/eventing/samples/kubernetes-event-source/ which would allow you to produce events that could then be consumed/filtered by Tekton Triggers.

Oh, thank you. We're looking into knative eventing right now, but that seem to be pretty complex tool, yet pretty rigid, so writing our own small trigger controller looks easier and more flexible in short term.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 14, 2020
@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Aug 14, 2020
@dibyom dibyom reopened this Aug 14, 2020
@dibyom dibyom closed this as completed Aug 14, 2020
@dbazhal
Copy link
Author

dbazhal commented Aug 21, 2020

So if I'm not updating feature request every month, it's "rejected"?

@dbazhal
Copy link
Author

dbazhal commented Sep 15, 2020

Can this please be reopened?) Would like to see this in future

@dibyom dibyom reopened this Sep 15, 2020
@dibyom dibyom removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2020
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2020
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 13, 2021
@ibotty
Copy link

ibotty commented Mar 3, 2021

It's still relevant. Please remove label.

@jmcshane
Copy link
Contributor

one thing to note here is that if you use case is to trigger on something around a pipelinerun/taskrun executing, you can use the cloudevent configuration on the config-defaults tekton-pipelines configmap to send those events to a target eventlistener. if you need to send those across multiple eventlisteners, you can use a forwarder to send those events to multiple targets (without needing to deploy knative).

@jmcshane
Copy link
Contributor

https://tekton.dev/docs/pipelines/events/#events-via-cloudevents

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ibotty
Copy link

ibotty commented May 12, 2021

On OpenShift/OKD I'd like to trigger on Changes in ImageStreamTags. I'd like to reopen that issue.

@dibyom
Copy link
Member

dibyom commented May 13, 2021

@ibotty Would you mind opening a new GH issue for that? Thanks!

@ibotty
Copy link

ibotty commented May 13, 2021

But wouldn't it be the same issue as that one? Or do you mean specifically for ImageStreamTags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants