Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make instructions in DEVELOPMENT guide work #7

Closed
bobcatfish opened this issue Jun 23, 2019 · 4 comments
Closed

Make instructions in DEVELOPMENT guide work #7

bobcatfish opened this issue Jun 23, 2019 · 4 comments
Assignees
Milestone

Comments

@bobcatfish
Copy link
Collaborator

bobcatfish commented Jun 23, 2019

Expected behavior

Folks who try to follow along with our DEVELOPMENT.md should be able to actually run the commands.

(of course one way to meet this would be to delete the stuff we don't have yet, but I think it would put us in a great position to add all the supporting code we need to just make it work!)

Actual behavior

We have no code yet, so most of the contents of the DEVELOPMENT.md would not work.

I copied most of the DEVELOPMENT.md contents from https://github.com/tektoncd/pipeline/blob/master/DEVELOPMENT.md but didn't copy the supporting code (e.g. hack dir).

Some things I noticed that we could probably make work fairly easily, that would set us up nicely:

Additional info

@ncskier ncskier self-assigned this Jul 10, 2019
@ncskier
Copy link
Member

ncskier commented Jul 10, 2019

@bobcatfish to clarify, are we making it possible to install triggers independently from pipeline? If so, we'll need to add yaml for our own Namespace, ClusterRole, ServiceAccount, ClusterRoleBinding, etc. (some of these might be duplicates from pipeline; for example, the Namespace could be the same yaml file that's in pipeline?).

@ncskier
Copy link
Member

ncskier commented Jul 11, 2019

I followed up with @bobcatfish about my previous comment, and I will proceed with this issue under the assumption that users can install triggers without having installed pipelines (although they will work best together). The triggers project will be installed into the tekton-pipelines namespace, but will use its own ServiceAccount.

@ncskier ncskier mentioned this issue Jul 15, 2019
3 tasks
@ncskier
Copy link
Member

ncskier commented Jul 23, 2019

Closing this issue now that ko apply -f config/ works, the hack directory (with update-deps and update-codegen) works, and the skeleton controller & webhook exist.

Relevant PRs:

@ncskier ncskier closed this as completed Jul 23, 2019
@bobcatfish
Copy link
Collaborator Author

niiiiice 🎉

image

@bobcatfish bobcatfish added this to the Triggers 0.1 milestone Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants