Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a skeleton webhook that does nothing #9

Closed
bobcatfish opened this issue Jun 23, 2019 · 2 comments
Closed

Create a skeleton webhook that does nothing #9

bobcatfish opened this issue Jun 23, 2019 · 2 comments
Assignees
Milestone

Comments

@bobcatfish
Copy link
Collaborator

It will be easier for ppl to start adding functionality if we add an empty webhook that doesn't actually do anything (eventually this webhook controller will be used to verify Trigger types), just:

  • Has all the config needed to build and deploy with ko
  • Instantiates an admission controller that isn't actually doing anything, e.g.:
	controller := webhook.AdmissionController{
		Client:  kubeClient,
		Options: options,
		Handlers: map[schema.GroupVersionKind]webhook.GenericCRD{
			// nothing actually here cuz we don't have any types yet
		},
		Logger: logger,
	}

Additional info

Continuing to use knative/pkg is probably our best bet for now, in which case we can get a lot of this by more or less copying https://github.com/tektoncd/pipeline/tree/master/cmd/controller.

@vincent-pli
Copy link
Member

vincent-pli commented Jul 9, 2019

/assign @vincent-pli

@bobcatfish
Copy link
Collaborator Author

I think this is fixed by #21 thanks @vincent-pli !!! (plz re-open if I'm wrong :D)

@bobcatfish bobcatfish added this to the Triggers 0.1 milestone Aug 21, 2019
chmouel pushed a commit to chmouel/tektoncd-triggers that referenced this issue Feb 10, 2020
No need for a builder image since we are doing from CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants