TriggerTemplate errors with \n character #942

dibyom · 2021-02-04T18:07:49Z

Expected Behavior

Users should be able to use a Trigger with binding or template param values that contain the newline \n character.

Actual Behavior

TriggerTemplate errors out. I tried a few cases cases -- 1) TriggerTemplate with a default param that contains a newline, 2) with the annotation triggers.tekton.dev/old-escape-quotes: "true" added, and 3) with a binding value that contains the new line param.

Steps to Reproduce the Problem

apiVersion: triggers.tekton.dev/v1alpha1
kind: Trigger
metadata:
  name: newline-params
spec:
  bindings:
    - name: extra
      value: |
        {
          "type": "section",
          "foo": "bar"
        }
  template:
    ref: "newline-params"
---
apiVersion: triggers.tekton.dev/v1alpha1
kind: TriggerTemplate
metadata:
  name: newline-params
  annotations:
spec:
  params:
  - name: "extra"
    default: |
        {
            "type": "section"
        }
  resourcetemplates:
    - apiVersion: tekton.dev/v1alpha1
      kind: TaskRun
      metadata:
        generateName: newline-params-
      spec:
        taskSpec:
          steps:
          - name: "hellothere"
            image: ubuntu
            script: echo "$(tt.params.extra)"
---
apiVersion: triggers.tekton.dev/v1alpha1
kind: EventListener
metadata:
  name: listener-triggerref
spec:
  serviceAccountName: tekton-triggers-example-sa
  triggers:
    - triggerRef: "newline-params"

Additional Info

TEP on escaping quotes: Escaping quotes in TriggerTemplates. community#321
earlier bug report: TriggerBinding doesn't support multiline string param? #772
Tekton Triggers version: v0.11.2

Error logs

{"level":"info","ts":"2021-02-04T17:39:02.730Z","logger":"eventlistener","caller":"sink/sink.go:234","msg":"ResolvedParams : [{Name:extra Value:{\n  \"type\": \"section\"\n}\n}]","knative.dev/controller":"eventlistener","/triggers-eventid":"khdmd","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"234","function":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger"}}
{"level":"error","ts":"2021-02-04T17:39:02.730Z","logger":"eventlistener","caller":"sink/sink.go:337","msg":"problem creating obj: &errors.errorString{s:\"couldn't unmarshal json from the TriggerTemplate: invalid character '\\\\n' in string literal\"}","knative.dev/controller":"eventlistener","/triggers-eventid":"khdmd","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"337","function":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:337\ngithub.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:236\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:125"}
{"level":"error","ts":"2021-02-04T17:39:02.730Z","logger":"eventlistener","caller":"sink/sink.go:237","msg":"couldn't unmarshal json from the TriggerTemplate: invalid character '\\n' in string literal","knative.dev/controller":"eventlistener","/triggers-eventid":"khdmd","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"237","function":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:237\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:125"}
{"level":"error","ts":"2021-02-04T17:42:14.604Z","logger":"eventlistener","caller":"sink/sink.go:177","msg":"Error getting Trigger trigger in Namespace default: trigger.triggers.tekton.dev \"trigger\" not found","knative.dev/controller":"eventlistener","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"177","function":"github.com/tektoncd/triggers/pkg/sink.Sink.merge"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.merge\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:177\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:116\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2042\nnet/http.(*ServeMux).ServeHTTP\n\tnet/http/server.go:2417\nnet/http.(*timeoutHandler).ServeHTTP.func1\n\tnet/http/server.go:3272"}
{"level":"info","ts":"2021-02-04T17:42:14.604Z","logger":"eventlistener","caller":"sink/sink.go:234","msg":"ResolvedParams : [{Name:extra Value:{\n    \"type\": \"section\"\n}\n}]","knative.dev/controller":"eventlistener","/triggers-eventid":"85dd2","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"234","function":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger"}}
{"level":"error","ts":"2021-02-04T17:42:14.605Z","logger":"eventlistener","caller":"sink/sink.go:337","msg":"problem creating obj: &errors.errorString{s:\"couldn't unmarshal json from the TriggerTemplate: invalid character '\\\\n' in string literal\"}","knative.dev/controller":"eventlistener","/triggers-eventid":"85dd2","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"337","function":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:337\ngithub.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:236\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:125"}
{"level":"error","ts":"2021-02-04T17:42:14.605Z","logger":"eventlistener","caller":"sink/sink.go:237","msg":"couldn't unmarshal json from the TriggerTemplate: invalid character '\\n' in string literal","knative.dev/controller":"eventlistener","/triggers-eventid":"85dd2","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"237","function":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:237\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:125"}
{"level":"error","ts":"2021-02-04T17:43:43.815Z","logger":"eventlistener","caller":"sink/sink.go:177","msg":"Error getting Trigger trigger in Namespace default: trigger.triggers.tekton.dev \"trigger\" not found","knative.dev/controller":"eventlistener","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"177","function":"github.com/tektoncd/triggers/pkg/sink.Sink.merge"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.merge\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:177\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:116\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2042\nnet/http.(*ServeMux).ServeHTTP\n\tnet/http/server.go:2417\nnet/http.(*timeoutHandler).ServeHTTP.func1\n\tnet/http/server.go:3272"}
{"level":"info","ts":"2021-02-04T17:43:43.815Z","logger":"eventlistener","caller":"sink/sink.go:234","msg":"ResolvedParams : [{Name:extra Value:{\n    \"type\": \"section\"\n}\n}]","knative.dev/controller":"eventlistener","/triggers-eventid":"zdb5r","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"234","function":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger"}}
{"level":"error","ts":"2021-02-04T17:43:43.815Z","logger":"eventlistener","caller":"sink/sink.go:337","msg":"problem creating obj: &errors.errorString{s:\"couldn't unmarshal json from the TriggerTemplate: invalid character '\\\\n' in string literal\"}","knative.dev/controller":"eventlistener","/triggers-eventid":"zdb5r","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"337","function":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:337\ngithub.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:236\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:125"}
{"level":"error","ts":"2021-02-04T17:43:43.815Z","logger":"eventlistener","caller":"sink/sink.go:237","msg":"couldn't unmarshal json from the TriggerTemplate: invalid character '\\n' in string literal","knative.dev/controller":"eventlistener","/triggers-eventid":"zdb5r","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"237","function":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:237\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:125"}
{"level":"error","ts":"2021-02-04T17:45:25.452Z","logger":"eventlistener","caller":"sink/sink.go:177","msg":"Error getting Trigger trigger in Namespace default: trigger.triggers.tekton.dev \"trigger\" not found","knative.dev/controller":"eventlistener","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"177","function":"github.com/tektoncd/triggers/pkg/sink.Sink.merge"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.merge\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:177\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:116\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2042\nnet/http.(*ServeMux).ServeHTTP\n\tnet/http/server.go:2417\nnet/http.(*timeoutHandler).ServeHTTP.func1\n\tnet/http/server.go:3272"}
{"level":"info","ts":"2021-02-04T17:45:25.452Z","logger":"eventlistener","caller":"sink/sink.go:234","msg":"ResolvedParams : [{Name:extra Value:{\n  \"type\": \"section\",\n  \"foo\": \"bar\"\n}\n}]","knative.dev/controller":"eventlistener","/triggers-eventid":"42fnn","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"234","function":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger"}}
{"level":"error","ts":"2021-02-04T17:45:25.452Z","logger":"eventlistener","caller":"sink/sink.go:337","msg":"problem creating obj: &errors.errorString{s:\"couldn't unmarshal json from the TriggerTemplate: invalid character '\\\\n' in string literal\"}","knative.dev/controller":"eventlistener","/triggers-eventid":"42fnn","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"337","function":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:337\ngithub.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:236\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:125"}
{"level":"error","ts":"2021-02-04T17:45:25.452Z","logger":"eventlistener","caller":"sink/sink.go:237","msg":"couldn't unmarshal json from the TriggerTemplate: invalid character '\\n' in string literal","knative.dev/controller":"eventlistener","/triggers-eventid":"42fnn","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"237","function":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:237\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:125"}
{"level":"error","ts":"2021-02-04T17:51:55.054Z","logger":"eventlistener","caller":"sink/sink.go:177","msg":"Error getting Trigger trigger in Namespace default: trigger.triggers.tekton.dev \"trigger\" not found","knative.dev/controller":"eventlistener","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"177","function":"github.com/tektoncd/triggers/pkg/sink.Sink.merge"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.merge\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:177\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:116\nnet/http.HandlerFunc.ServeHTTP\n\tnet/http/server.go:2042\nnet/http.(*ServeMux).ServeHTTP\n\tnet/http/server.go:2417\nnet/http.(*timeoutHandler).ServeHTTP.func1\n\tnet/http/server.go:3272"}
{"level":"info","ts":"2021-02-04T17:51:55.054Z","logger":"eventlistener","caller":"sink/sink.go:234","msg":"ResolvedParams : [{Name:extra Value:{\n  \"type\": \"section\",\n  \"foo\": \"bar\"\n}\n}]","knative.dev/controller":"eventlistener","/triggers-eventid":"bxfn5","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"234","function":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger"}}
{"level":"error","ts":"2021-02-04T17:51:55.054Z","logger":"eventlistener","caller":"sink/sink.go:337","msg":"problem creating obj: &errors.errorString{s:\"couldn't unmarshal json from the TriggerTemplate: invalid character '\\\\n' in string literal\"}","knative.dev/controller":"eventlistener","/triggers-eventid":"bxfn5","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"337","function":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:337\ngithub.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:236\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:125"}
{"level":"error","ts":"2021-02-04T17:51:55.054Z","logger":"eventlistener","caller":"sink/sink.go:237","msg":"couldn't unmarshal json from the TriggerTemplate: invalid character '\\n' in string literal","knative.dev/controller":"eventlistener","/triggers-eventid":"bxfn5","/trigger":"newline-params","logging.googleapis.com/labels":{},"logging.googleapis.com/sourceLocation":{"file":"github.com/tektoncd/triggers/pkg/sink/sink.go","line":"237","function":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger"},"stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:237\ngithub.com/tektoncd/triggers/pkg/sink.Sink.HandleEvent.func1\n\tgithub.com/tektoncd/triggers/pkg/sink/sink.go:125"}

The text was updated successfully, but these errors were encountered:

jmcshane · 2021-02-10T01:18:04Z

So @dibyom it looks like newlines that are set as parameters passed in at https://github.com/tektoncd/triggers/blob/master/pkg/resources/create.go#L69 need to be escaped in order to pass as newlines. Unfortunately, it looks like you have to know where that newline string goes in the resolved template. If it shows up in a pipelinev1.ArrayOrString parameter, it needs to be escaped there before it is populated. As you can see in sink_test.go, when it is passed into a label this issue isn't present.

Basically, this is about how the triggertemplate is populated with values. You need to know the context of the type that the resolved string is being placed into.

jmcshane · 2021-02-10T01:20:27Z

The problem with finding this context is that triggers replaces the byte arrays in a json.RawMessage, so that context isn't available: https://github.com/tektoncd/triggers/blob/master/pkg/template/resource.go#L135

Closes tektoncd#942 This PR resolves the bug by replacing all instances of the \n character in triggerbinding params with \n, thus encoding into JSON as the bytes 92 110 rather than 10 or 13 10 depending on the system. This works in any instance where the parameter is substituted as the JSON encoding will resolve the parameter value after the byte array for the constructed rawMessage is assembled. Therefore, anywhere that the newline character is in one of these parameters, it will not encode appropriately in JSON. This was determined based on the existing tests that use \n in the label fields. Since the JSON encoder already operate successfully with those fields, we can look at the resultant byte array when those tests are run and determine the appropriate input that should be passed to the replace function in resource.go

jmcshane · 2021-02-10T03:58:13Z

Scratch that, we can just encode this by escaping the newline anywhere the param is replaced. Submitted PR #953

tekton-robot · 2021-05-11T04:40:41Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

dibyom · 2021-07-01T21:31:46Z

So, in #953 (comment) I had suggested that we revive and merge #953. I did a bit more digging and it looks like the problem with newline characters is restricted mainly to YAML multilines i.e. either trigger binding values or trigger template param defaults containing YAML multiline strings. If the incoming event body contains a \n, Trigger processing does not fail

tekton-robot · 2021-10-15T17:01:28Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot · 2021-11-14T17:14:28Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

dibyom · 2021-11-15T16:48:01Z

(This is still a issue we need to fix)

lbernick · 2021-12-13T20:47:43Z

/priority important-longterm

OSobky · 2021-12-14T14:51:53Z

Now I am facing a similar problem when I have string array in the JSON body sent to Event Listener

dibyom · 2022-01-07T22:01:59Z

hi @OSobky do you have a quick example of your use case that is failing?

OSobky · 2022-01-17T11:03:25Z

Hey @dibyom, Sorry for the late reply. Sure!

Basically, I was trying to send a request with an array of strings in the JSON body like the following:
{ "PARAMETERS" : ["-P", "alpha=0.555" , "-P" ,"l1_ratio=0.222"] }

However, the event listener generates the following error:
{"level":"error","logger":"eventlistener","caller":"sink/sink.go:339","msg":"problem creating obj: &errors.errorString{s:\"couldn't unmarshal json from the TriggerTemplate: invalid character '-' after object key:value pair\"}","knative.dev/controller":"eventlistener","/triggers-eventid":"7c6eac30-50a8-4ef9-8db6-877d6734d170","/trigger":"triggers","stacktrace":"github.com/tektoncd/triggers/pkg/sink.Sink.CreateResources\n\t/opt/app-root/src/go/src/github.com/tektoncd/triggers/pkg/sink/sink.go:339\ngithub.com/tektoncd/triggers/pkg/sink.Sink.processTrigger\n\t/opt/approot/src/go/src/github.com/tektoncd/triggers/pkg/sink/sink.go:238\ngithub.com/tektoncd/triggers/pkg/sink.Sik.HandleEvent.func1\n\t/opt/app-root/src/go/src/github.com/tektoncd/triggers/pkg/sink/sink.go:127"}

Let me know if you need more detailed example

tekton-robot · 2022-04-17T11:18:43Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

dibyom added the kind/bug Categorizes issue or PR as related to a bug. label Feb 4, 2021

jmcshane mentioned this issue Feb 10, 2021

Resolving newline in TriggerBinding param #953

Closed

4 tasks

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2021

dibyom removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2021

dibyom added this to the Triggers Beta milestone May 12, 2021

dibyom self-assigned this Jun 7, 2021

dibyom modified the milestones: Triggers Beta, Triggers Post Beta Jul 2, 2021

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 15, 2021

tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 14, 2021

dibyom removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 15, 2021

tekton-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Dec 13, 2021

tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2022

dibyom added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 20, 2022

xchapter7x added this to Tekton Community Roadmap Sep 20, 2022

xchapter7x moved this to Todo in Tekton Community Roadmap Sep 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TriggerTemplate errors with \n character #942

TriggerTemplate errors with \n character #942

dibyom commented Feb 4, 2021 •

edited

Loading

jmcshane commented Feb 10, 2021

jmcshane commented Feb 10, 2021

jmcshane commented Feb 10, 2021

tekton-robot commented May 11, 2021

dibyom commented Jul 1, 2021

tekton-robot commented Oct 15, 2021

tekton-robot commented Nov 14, 2021

dibyom commented Nov 15, 2021

lbernick commented Dec 13, 2021

OSobky commented Dec 14, 2021

dibyom commented Jan 7, 2022 •

edited

Loading

OSobky commented Jan 17, 2022 •

edited

Loading

tekton-robot commented Apr 17, 2022

TriggerTemplate errors with \n character #942

TriggerTemplate errors with \n character #942

Comments

dibyom commented Feb 4, 2021 • edited Loading

Expected Behavior

Actual Behavior

Steps to Reproduce the Problem

Additional Info

Error logs

jmcshane commented Feb 10, 2021

jmcshane commented Feb 10, 2021

jmcshane commented Feb 10, 2021

tekton-robot commented May 11, 2021

dibyom commented Jul 1, 2021

tekton-robot commented Oct 15, 2021

tekton-robot commented Nov 14, 2021

dibyom commented Nov 15, 2021

lbernick commented Dec 13, 2021

OSobky commented Dec 14, 2021

dibyom commented Jan 7, 2022 • edited Loading

OSobky commented Jan 17, 2022 • edited Loading

tekton-robot commented Apr 17, 2022

dibyom commented Feb 4, 2021 •

edited

Loading

dibyom commented Jan 7, 2022 •

edited

Loading

OSobky commented Jan 17, 2022 •

edited

Loading