Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use knative "adapter" to simplify event listener sink #1207

Merged
merged 4 commits into from
Sep 8, 2021

Commits on Aug 30, 2021

  1. Use knative "adapter" to simplify event listener sink.

    This simplifies the event listener sink by adopting the knative eventing "adapter" library, which is like our sharedmain for controlplanes, but for the eventing dataplane components.  This pattern passes config data as JSON in `env:`, so it also dramatically simplifies the controller logic because we no longer need to copy around empty configmaps and clean them up, and net removes a lot of code.
    
    This also takes advantage of the new dynamic client injection logic to reduce the overhead of each adapter on the API server, and potentially dramatically improves cold start time of ksvc based sinks (they no longer need to sync informers to handle traffic).  If this proves troublesome, it should be relatively straightforward to switch things back.
    mattmoor committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    1e97e8a View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Add dropped !

    mattmoor committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    148edb2 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Configuration menu
    Copy the full SHA
    6dad1ed View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Drop commented code

    mattmoor committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    125ad71 View commit details
    Browse the repository at this point in the history