Allow creating v1alpha1 Run types #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like an unintentional omission since we do allow creating TriggerTemplates with the Run kind. Addressing tektoncd#494 should have caught this earlier.
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XS
|
/test pull-tekton-triggers-integration-tests |
lbernick
added a commit
to lbernick/plumbing
that referenced
this pull request
Dec 9, 2021
Dogfooding Pipeline to Taskrun is part of our strategy for creating a successor to PipelineResources. This commit rewrites the mario image builder trigger template to use a PipelineRun containing a PipelineToTaskRun, plus a finally Task, and rewrites the mario github trigger template to use a Run of kind PipelineToTaskRun. PipelineToTaskRun does not support workspace mountPaths or finally Tasks, so this commit rewrites existing pipelines to avoid using those features in a PipelineToTaskRun. In addition, PipelineToTaskRun does not support OCI bundles, so the pull-request and git-clone tasks were installed in the mario namespace of the dogfooding cluster. This commit requires updating Triggers in the dogfooding cluster to pull in [PR: support Runs in TriggerTemplates](tektoncd/triggers#1283).
2 tasks
|
/test pull-tekton-triggers-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
tekton-robot
pushed a commit
to tektoncd/plumbing
that referenced
this pull request
Jan 12, 2022
Dogfooding Pipeline to Taskrun is part of our strategy for creating a successor to PipelineResources. This commit rewrites the mario image builder trigger template to use a PipelineRun containing a PipelineToTaskRun, plus a finally Task, and rewrites the mario github trigger template to use a Run of kind PipelineToTaskRun. PipelineToTaskRun does not support workspace mountPaths or finally Tasks, so this commit rewrites existing pipelines to avoid using those features in a PipelineToTaskRun. In addition, PipelineToTaskRun does not support OCI bundles, so the pull-request and git-clone tasks were installed in the mario namespace of the dogfooding cluster. This commit requires updating Triggers in the dogfooding cluster to pull in [PR: support Runs in TriggerTemplates](tektoncd/triggers#1283).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This seems like an unintentional omission since we do allow creating
TriggerTemplates with the Run kind.
Addressing #494 should have caught this earlier.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes