Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Default HTTPClient in favour Custom HTTPClient #1308

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Remove Default HTTPClient in favour Custom HTTPClient #1308

merged 1 commit into from
Feb 19, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Feb 9, 2022 •
edited
Loading

Default HTTP client provided by go can cause leak, hangup and other issues. It has no sane timeout defined.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 9, 2022
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 9, 2022
@khrm khrm added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 10, 2022
@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2022
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2022
@khrm khrm force-pushed the httpClient branch 5 times, most recently from fe2e1aa to 2d38a17 Compare February 16, 2022 08:25
@khrm
Remove Default HTTPClient in favour Custom HTTPClient
6d65e62 
Default HTTP client provided by go can cause leak, hangup
and other issues because it has no sane timeout defined.
@savitaashture savitaashture added this to the Triggers v0.19 milestone Feb 16, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2022
savitaashture
savitaashture reviewed Feb 19, 2022
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

🎉 👍

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2022
@tekton-robot tekton-robot merged commit b62f296 into tektoncd:main Feb 19, 2022
@khrm khrm deleted the httpClient branch February 28, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture left review comments

@dibyom dibyom dibyom approved these changes

@ncskier ncskier Awaiting requested review from ncskier

@vtereso vtereso Awaiting requested review from vtereso

Assignees

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.19
Development

Successfully merging this pull request may close these issues.
4 participants
@khrm @tekton-robot @dibyom @savitaashture