Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ko to v0.12.0 #1443

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Update ko to v0.12.0 #1443

merged 1 commit into from
Sep 6, 2022

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Sep 6, 2022 •
edited
Loading

We updated ko to v0.12.0 so that media layers are set consistently.
Reference issue: ko-build/ko#776

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@khrm
Update ko to v0.12.0
282cd26 
We updated ko to v0.12.0 so that media layers are set consistently.
Reference issue: ko-build/ko#776
@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Sep 6, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 6, 2022
khrm
khrm commented Sep 6, 2022
View reviewed changes
Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Sep 6, 2022
@khrm khrm added this to the Triggers v0.21.0 milestone Sep 6, 2022
savitaashture
savitaashture approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 6, 2022
@tekton-robot tekton-robot merged commit 32a5723 into main Sep 6, 2022
@khrm khrm deleted the khrm-patch-1 branch September 12, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savitaashture savitaashture savitaashture approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@vtereso vtereso Awaiting requested review from vtereso

Assignees

@savitaashture savitaashture

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Triggers v0.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@khrm @tekton-robot @savitaashture