Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the Knative package and Serving version to align with the Kubernetes version for compatibility #1691

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Modify the Knative package and Serving version to align with the Kubernetes version for compatibility #1691

merged 1 commit into from
Feb 8, 2024

Conversation

savitaashture
Copy link
Contributor

Changes

Fixes : tektoncd/operator#1968 (comment)

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Feb 8, 2024
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 8, 2024
@savitaashture savitaashture requested review from dibyom and removed request for bobcatfish and iancoffey February 8, 2024 04:59
@savitaashture savitaashture added this to the Triggers v0.26.1 milestone Feb 8, 2024
khrm
khrm reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2024
@khrm
Copy link
Contributor

khrm commented Feb 8, 2024

/cherry-pick release-v0.26.x

@tekton-robot
Copy link

@khrm: once the present PR merges, I will cherry-pick it on top of release-v0.26.x in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.26.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@khrm khrm requested a review from vdemeester February 8, 2024 05:54
@khrm
Copy link
Contributor

khrm commented Feb 8, 2024

@vdemeester Can you give approval here?

@khrm
Copy link
Contributor

khrm commented Feb 8, 2024

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@tekton-robot tekton-robot merged commit cab8f01 into tektoncd:main Feb 8, 2024
6 checks passed
@khrm
Copy link
Contributor

khrm commented Feb 8, 2024

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Feb 8, 2024
@tekton-robot
Copy link

@khrm: new pull request created: #1692

In response to this:

/cherry-pick release-v0.26.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot mentioned this pull request Feb 8, 2024
Merged
@savitaashture savitaashture removed this from the Triggers v0.26.1 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khrm khrm khrm left review comments

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@dibyom dibyom Awaiting requested review from dibyom

Assignees

@khrm khrm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@savitaashture @khrm @tekton-robot @vdemeester