Update eventlistener podSeurityContext to adhere to restricted pod se… #1740

kristofferchr · 2024-07-01T22:11:47Z

Solves issue #1739

Currently, when el-security-context is enabled, the securityContext for EventListener in the pod template only sets runAsNonRoot. Expanding podTemplate securityContext can make it easier to fulfill restricted pod security standards.

Makes it possible to have a default securityContext set for injected sidecar containers that does not fulfill restricted pod security standars. An example of this is injected istio containers.

Changes

Alter podSecurityContext to include seccompProfile, runAsUser, runAsGroup and fsGroup when set-security-context is set.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Eventlistener podTemplate now includes securityContext settings: seccompProfile, runAsUser, runAsGroup, and fsGroup when flag el-security-context is true.

tekton-robot · 2024-07-01T22:11:56Z

Hi @kristofferchr. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

linux-foundation-easycla · 2024-07-01T22:12:09Z

The committers listed above are authorized under a signed CLA.

✅ login: kristofferchr / name: Kristoffer Moberg Christensen (19b92f4)

kristofferchr · 2024-07-01T22:12:15Z

/kind feature

khrm

/ok-to-test

kristofferchr · 2024-07-02T08:06:58Z

/retest

kristofferchr · 2024-07-02T18:24:42Z

/retest

savitaashture · 2024-07-04T05:40:28Z

pkg/reconciler/eventlistener/resources/deployment.go

+func getStrongerSecurityPolicy(cfg *config.Config) corev1.PodSecurityContext {
+	securityContext := baseStrongerSecurityPolicy
+	securityContext.RunAsUser = ptr.Int64(cfg.Defaults.DefaultRunAsUser)
+	securityContext.RunAsGroup = ptr.Int64(cfg.Defaults.DefaultRunAsGroup)
+	securityContext.FSGroup = ptr.Int64(cfg.Defaults.DefaultRunAsGroup)
+	return securityContext
+}
+


We already setting these values here https://github.com/tektoncd/triggers/blob/main/pkg/reconciler/eventlistener/resources/container.go#L53-L68

except FSGroup

if you want to add FSGroup can you update this https://github.com/tektoncd/triggers/blob/main/pkg/reconciler/eventlistener/resources/container.go#L53-L68 part of the code

I checked my specific use case again(istio injected sidecars) and it appears runAsGroup and runAsUser is set for that container.

However, i would like to keep seccompProfile as it is not set and therefore violates restricted pod security standards.
FSGroup is not available in container securityContext, only PodSecurityContext.

I can remove runAsGroup and runAsUser if you do not wish to have a pod level default.

I think we can keep for pod level as well i don't see issue

cc @khrm @dibyom

Is there anything that is missing or changes that is required for this PR before approval?

Ping @savitaashture @khrm

kristofferchr · 2024-08-05T11:53:20Z

bump @khrm @savitaashture

savitaashture · 2024-08-05T16:07:25Z

pkg/reconciler/eventlistener/resources/deployment.go

+	securityContext.RunAsUser = ptr.Int64(cfg.Defaults.DefaultRunAsUser)
+	securityContext.RunAsGroup = ptr.Int64(cfg.Defaults.DefaultRunAsGroup)


Hi @kristofferchr
For runAsUser and runAsGroup
can you handle similar to this https://github.com/tektoncd/triggers/blob/main/pkg/reconciler/eventlistener/resources/container.go#L71-L76
because In a platform like OpenShift we set "" value so lets keep runAsUser and runAsGroup when its actually set

Certainly. FSGroup as well?

Implemented and added tests.

savitaashture · 2024-08-06T07:51:28Z

pkg/reconciler/eventlistener/resources/deployment.go

+
+	if !cfg.Defaults.IsDefaultRunAsGroupEmpty {
+		securityContext.RunAsGroup = ptr.Int64(cfg.Defaults.DefaultRunAsGroup)
+		securityContext.FSGroup = ptr.Int64(cfg.Defaults.DefaultRunAsGroup)


Is FSGroup and runAsGroup same ??

I set them as the same, as i do not need change it for my use case. Should i make it configurable through a Defaults or wait for a specific use case?

IMO lets wait for a specific case
we can add it whenever we have usecase

agreed. I will keep it as it is with FSGroup set to RunAsGroup

Oh wait my point is can we completly remove FSGroup or is it required ?

I need it for my usecase to adhere to aks policy: https://github.com/Azure/azure-policy/blob/master/built-in-policies/policySetDefinitions/Kubernetes/PSPRestrictedStandard.json#L256

Currently we need policy exemptions because of this requirement.

I set them as the same, as i do not need change it for my use case. Should i make it configurable through a Defaults or wait for a specific use case?

Shall we configure it so that if someone wants they can set to different value
as both FSGroup and RUnAsGroup functionality is different

Once you add the configuration for FSGroup smilar to RunAsGroup I think we are good to merge

@savitaashture updated :)

kristofferchr · 2024-08-06T08:04:13Z

/retest

…curity standards Alter podSecurityContext to include seccompProfile, runAsUser, runAsGroup and fsGroup when set-security-context is set. As podSecurityContext only included runAsNonRoot, which could cause injected sidecars to miss some required restricted pod security standards securityContext fields.

tekton-robot · 2024-08-16T11:29:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/config/default.go	88.2%	87.8%	-0.4

tekton-robot · 2024-08-19T08:10:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [savitaashture]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

khrm

/lgtm

…curityContext for Triggers as part of this PR tektoncd/triggers#1740 we've introduced an FSGroup setting to comply with restricted pod security standards for the podTemplate. But the default value 65532 won't work on OpenShift so setting by default for FSGroup Signed-off-by: Savita Ashture <sashture@redhat.com>

tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 1, 2024

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 1, 2024

tekton-robot requested review from bobcatfish and dibyom July 1, 2024 22:11

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 1, 2024

khrm reviewed Jul 2, 2024

View reviewed changes

tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2024

kristofferchr force-pushed the feature/add-stronger-security-context-pod-template branch 2 times, most recently from cf0b25d to 53e47ba Compare July 2, 2024 20:30

savitaashture reviewed Jul 4, 2024

View reviewed changes

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2024

kristofferchr force-pushed the feature/add-stronger-security-context-pod-template branch from 53e47ba to 38745aa Compare July 15, 2024 10:41

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2024

kristofferchr force-pushed the feature/add-stronger-security-context-pod-template branch 2 times, most recently from dedb181 to c91c57b Compare July 15, 2024 10:49

savitaashture reviewed Aug 5, 2024

View reviewed changes

kristofferchr force-pushed the feature/add-stronger-security-context-pod-template branch from c91c57b to f669160 Compare August 6, 2024 07:41

savitaashture reviewed Aug 6, 2024

View reviewed changes

kristofferchr force-pushed the feature/add-stronger-security-context-pod-template branch from f669160 to 10b5ec4 Compare August 6, 2024 08:38

kristofferchr force-pushed the feature/add-stronger-security-context-pod-template branch from 10b5ec4 to 19b92f4 Compare August 16, 2024 11:23

savitaashture approved these changes Aug 19, 2024

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024

khrm reviewed Aug 19, 2024

View reviewed changes

tekton-robot assigned khrm Aug 19, 2024

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2024

tekton-robot merged commit e4cd11d into tektoncd:main Aug 19, 2024
6 checks passed

savitaashture mentioned this pull request Aug 19, 2024

Update triggers default configmap for FSGroup to handle restricted securityContext for Triggers tektoncd/operator#2285

Merged

4 tasks

kristofferchr deleted the feature/add-stronger-security-context-pod-template branch August 19, 2024 08:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update eventlistener podSeurityContext to adhere to restricted pod se… #1740

Update eventlistener podSeurityContext to adhere to restricted pod se… #1740

kristofferchr commented Jul 1, 2024 •

edited

Loading

tekton-robot commented Jul 1, 2024

linux-foundation-easycla bot commented Jul 1, 2024 •

edited

Loading

kristofferchr commented Jul 1, 2024

khrm left a comment

kristofferchr commented Jul 2, 2024

kristofferchr commented Jul 2, 2024

savitaashture Jul 4, 2024

kristofferchr Jul 4, 2024

savitaashture Jul 5, 2024

kristofferchr Jul 15, 2024 •

edited

Loading

kristofferchr Jul 17, 2024

kristofferchr commented Aug 5, 2024

savitaashture Aug 5, 2024

kristofferchr Aug 6, 2024 •

edited

Loading

kristofferchr Aug 6, 2024

savitaashture Aug 6, 2024

kristofferchr Aug 6, 2024

savitaashture Aug 6, 2024 •

edited

Loading

kristofferchr Aug 6, 2024

savitaashture Aug 6, 2024

kristofferchr Aug 6, 2024 •

edited

Loading

savitaashture Aug 12, 2024 •

edited

Loading

kristofferchr Aug 16, 2024

kristofferchr commented Aug 6, 2024

tekton-robot commented Aug 16, 2024

tekton-robot commented Aug 19, 2024

khrm left a comment

		securityContext.RunAsUser = ptr.Int64(cfg.Defaults.DefaultRunAsUser)
		securityContext.RunAsGroup = ptr.Int64(cfg.Defaults.DefaultRunAsGroup)

Update eventlistener podSeurityContext to adhere to restricted pod se… #1740

Update eventlistener podSeurityContext to adhere to restricted pod se… #1740

Conversation

kristofferchr commented Jul 1, 2024 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jul 1, 2024

linux-foundation-easycla bot commented Jul 1, 2024 • edited Loading

kristofferchr commented Jul 1, 2024

khrm left a comment

Choose a reason for hiding this comment

kristofferchr commented Jul 2, 2024

kristofferchr commented Jul 2, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kristofferchr Jul 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kristofferchr commented Aug 5, 2024

Choose a reason for hiding this comment

kristofferchr Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

savitaashture Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kristofferchr Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

savitaashture Aug 12, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kristofferchr commented Aug 6, 2024

tekton-robot commented Aug 16, 2024

tekton-robot commented Aug 19, 2024

khrm left a comment

Choose a reason for hiding this comment

kristofferchr commented Jul 1, 2024 •

edited

Loading

linux-foundation-easycla bot commented Jul 1, 2024 •

edited

Loading

kristofferchr Jul 15, 2024 •

edited

Loading

kristofferchr Aug 6, 2024 •

edited

Loading

savitaashture Aug 6, 2024 •

edited

Loading

kristofferchr Aug 6, 2024 •

edited

Loading

savitaashture Aug 12, 2024 •

edited

Loading