Use k8s types and validation code with the TriggerResourceTemplate type

[gabemontero]

Changes

This PR introduces some k8s alternatives to

• TriggerResourceTemplate raw payload (see Implement TriggerResourceTemplate Spec as []byte blob #51 (comment) through Implement TriggerResourceTemplate Spec as []byte blob #51 (comment) from last year, followed by Implement TriggerResourceTemplate Spec as []byte blob #51 (comment) through Implement TriggerResourceTemplate Spec as []byte blob #51 (comment) from a few days ago for history on the path to doing this)
• then while I was in here, I saw with the introduction of the dynamic clients the opportunity to use the k8s runtime scheme/decoder approach to validating the TriggerResourceTemplate

I delivered each in their own commit to facilitate the possibility of dropping one, but not both, of these changes.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• [/] Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• [/] Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

@dibyom @vdemeester @vtereso FYI / PTAL

thanks

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[tekton-robot]

Hi @gabemontero. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dibyom]

/ok-to-test

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/trigger_template_types.go	90.0%	100.0%	10.0
pkg/apis/triggers/v1alpha1/trigger_template_validation.go	96.8%	97.1%	0.3

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/trigger_template_types.go	90.0%	100.0%	10.0
pkg/apis/triggers/v1alpha1/trigger_template_validation.go	96.8%	97.1%	0.3

[gabemontero]

My initial guesses at filling out the CLA form were unsuccessful. I've sent a query out to the other RH tekton devs to find out what the secret sauce is.

[vdemeester]

😻

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[gabemontero]

OK I've been added to the RH/Google CLA

@googlebot I signed it!

[tekton-robot]

The following is the coverage report on pkg/.
Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1alpha1/trigger_template_types.go	90.0%	100.0%	10.0
pkg/apis/triggers/v1alpha1/trigger_template_validation.go	96.8%	97.1%	0.3

[gabemontero]

/assign @ncskier

[gabemontero]

I also have a commit to address the TODO at https://github.com/tektoncd/triggers/blob/master/pkg/apis/triggers/v1alpha1/trigger_template_validation.go#L34 and validate the ObjectMetadata for TriggerTemplate that I can push up if you all would like.

[dibyom]

This looks good to me! I don't think there should be any user facing changes here at all. Any concerns @wlynch @ncskier ?

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dibyom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dibyom]

I also have a commit to address the TODO at https://github.com/tektoncd/triggers/blob/master/pkg/apis/triggers/v1alpha1/trigger_template_validation.go#L34 and validate the ObjectMetadata for TriggerTemplate that I can push up if you all would like.

Sure, this or a new PR for that are both fine 😄

[gabemontero]

I also have a commit to address the TODO at https://github.com/tektoncd/triggers/blob/master/pkg/apis/triggers/v1alpha1/trigger_template_validation.go#L34 and validate the ObjectMetadata for TriggerTemplate that I can push up if you all would like.

Sure, this or a new PR for that are both fine smile

OK cool ... if anybody else requests changes on the existing stuff I'll push it up with those changes. Otherwise I'll just pull the commit into a new PR.

thanks

[gabemontero]

bump @wlynch @ncskier @dibyom

You all happy with the changes?

I do plan on joining the triggers sync call today if discussing this there is warranted in any of your opinions.

[wlynch]

/lgtm

This looks great! :D

Thanks for the change!

[gabemontero]

cool / thanks / glad to help @wlynch

I'll pull in that ObjectMetadata TODO into a new PR.