Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra columns for EventListeners #614

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

dibyom
Copy link
Member

@dibyom dibyom commented Jun 16, 2020

Changes

Adds the address.url and the Available status as additional columns, so users
running kubectl get can access them easily.

NAME                     ADDRESS                                                           AVAILABLE   REASON
gitlab-listener          http://el-gitlab-listener.default.svc.cluster.local:8080          True        MinimumReplicasAvailable
listener-embed-binding   http://el-listener-embed-binding.default.svc.cluster.local:8080   True        MinimumReplicasAvailable

Thanks to @n3wscott for the suggestion!!

/kind feature

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

EventListeners now display the status.address.url  and Available status.Condition as additional fields when listed with kubectl get

Adds the address.url and the `Available` status as additional columns, so users
running `kubectl get` can access them easily.

Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 16, 2020
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 16, 2020
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@tekton-robot tekton-robot merged commit 9baf220 into tektoncd:master Jun 16, 2020
@n3wscott
Copy link

Nicccce!!!

@dibyom dibyom deleted the columns branch June 17, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants