Fix getting-started triggers #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
dibyom
commented
Jun 26, 2020
| @@ -1,4 +0,0 @@ | |||
| apiVersion: v1 | |||
| kind: Namespace | |||
There was a problem hiding this comment.
Deleted this -- the docs explicitly mention creating the namespace. The formerly commented out test was using this. I replaced it with a call to create the namespace in the test script.
tekton-robot
added
size/M
The EventListener was referring to the Binding via `name` instead of `ref`. Also, run the getting-started examples as part of the e2e YAML tests. While this won't catch all issues with the examples, it should catch obvious syntax issues like this one. Fixes tektoncd#639 Fixes tektoncd#164 Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
|
/lgtm /approval |
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
AlanGreene
added a commit
to AlanGreene/website
that referenced
this pull request
Jul 15, 2020
Some of the Triggers content was moved in tektoncd/triggers#642, specifically: create-ingress.yaml and create-webhook.yaml These have been moved to the getting-started folder which broke the website sync script, blocking other changes. Update the sync config to point to the new paths to unblock other changes.
2 tasks
tekton-robot
pushed a commit
to tektoncd/website
that referenced
this pull request
Jul 20, 2020
Some of the Triggers content was moved in tektoncd/triggers#642, specifically: create-ingress.yaml and create-webhook.yaml These have been moved to the getting-started folder which broke the website sync script, blocking other changes. Update the sync config to point to the new paths to unblock other changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The EventListener was referring to the Binding via
nameinstead ofref. Also, run the getting-started examples as part of the e2e YAML tests. While this won't catch all issues with the examples, it should catch obvious syntax issues like this one.Fixes #639
Fixes #164
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
/kind bug