Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the Tekton Triggers installation instructions for clarity and flow #966

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Rewrite the Tekton Triggers installation instructions for clarity and flow #966

merged 1 commit into from
Feb 25, 2021

Conversation

tualeron
Copy link
Contributor

@tualeron tualeron commented Feb 23, 2021 •
edited
Loading

Changes

Rewrites the Tekton Triggers installation instructions for clarity and flow.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2021
@tualeron
Copy link
Contributor Author

/kind documentation

@tekton-robot tekton-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 23, 2021
MarcelMue
MarcelMue reviewed Feb 23, 2021
View reviewed changes
Copy link
Member

@MarcelMue MarcelMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the general direction.

docs/install.md Outdated Show resolved Hide resolved
docs/install.md Outdated Show resolved Hide resolved
@MarcelMue
Copy link
Member

I think a review from @dibyom would be good - he worked on these docs last.

/LGTM

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2021
dibyom
dibyom reviewed Feb 23, 2021
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergetron This looks much better! Only one small point about mentioning how to install k8s.

docs/install.md Outdated Show resolved Hide resolved
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@tualeron
Rewrite the Tekton Triggers installation instructions for clarity and…
e1a5aa4 
… flow.

Rewrites the Tekton Triggers installation instructions for clarity and flow.
@tualeron
Copy link
Contributor Author

Updated! Please review and re-LGTM.

dibyom
dibyom approved these changes Feb 25, 2021
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Serge!
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2021
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021
@tekton-robot tekton-robot merged commit 5388f35 into tektoncd:master Feb 25, 2021
@tualeron tualeron deleted the patch-1 branch March 2, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcelMue MarcelMue MarcelMue left review comments

@iancoffey iancoffey iancoffey left review comments

@dibyom dibyom dibyom approved these changes

Assignees

@dibyom dibyom

@MarcelMue MarcelMue

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tualeron @MarcelMue @tekton-robot @iancoffey @dibyom