Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline releases #623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

afrittoli
Copy link
Member

Changes

Add v0.64, and recent LTS and remove EOL releases

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Signed-off-by: Andrea Frittoli <andrea.frittoli@gmail.com>
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from afrittoli after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 27, 2024
RUN python3 -m venv .venv
RUN . .venv/bin/activate
RUN pip3 install -r requirements.txt
RUN pip3 install -r requirements.txt --break-system-packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't using venv the recommended approach? Is there a problem with a recent update to the hugo image that requires this now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last updated June 6, 2023… so not that. Something in the OS package repositories?

It might be worth a quick comment in the Dockerfile explaining why this approach is needed in case someone tries changing it back to venv in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants