Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipelines.md #624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update pipelines.md #624

wants to merge 1 commit into from

Conversation

prad9192
Copy link

@prad9192 prad9192 commented Sep 29, 2024

Updating the Getting started with Pipelines documentation

kind-v1.30.2 (tekton-pipelines) tkn pipelinerun logs hello-goodbye-run -f -n tekton-pipelines
[hello : echo] Hello world

[goodbye : goodbye] Goodbye Tekton

Copy link

linux-foundation-easycla bot commented Sep 29, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2024
@prad9192
Copy link
Author

/retest

@tekton-robot
Copy link

@prad9192: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prad9192
Copy link
Author

/assign @lucperkins

Copy link
Member

@AlanGreene AlanGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prad9192, thanks for the PR. Can you please clarify why this change is required?

I reviewed the getting started guide and default does appear to be the correct value here.

If you've updated your context to point to a different namespace that could explain why you had to modify the command.

I would perhaps suggest instead of changing default to tekton-pipelines here, we should add -n default to the kubectl apply commands to ensure the resources are created in the expected namespace regardless of the user's local config.

Typically you would not want to deploy additional resources into the tekton-pipelines namespace as it is reserved for the Tekton services themselves.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from lucperkins after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants