-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSP environment cleanup #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delay in opc() for TSPIEEE4882Commands
…script_name, and added the script_body input to allow usage without a local tsp file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 152 152
Lines 4899 4904 +5
Branches 780 780
=========================================
+ Hits 4899 4904 +5 ☔ View full report in Codecov by Sentry. |
nfelt14
requested changes
Oct 15, 2024
Blocked by PyCQA/docformatter#293 |
Co-authored-by: Nicholas Felt <nicholas.felt@tektronix.com> Signed-off-by: Luke <111022789+ldantek@users.noreply.github.com>
nfelt14
approved these changes
Oct 16, 2024
@ldantek, you will need to rebase your branch to get builds to pass |
Test Results (windows)
|
Test Results (ubuntu)
|
Test Results (macos)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change tweaks the cleanup function for TSPDevice children (excluding SCPI only 2400, 2401, 2410) to call
collectgarbage()
which cleanses the TSP environment of variables that have been set to nil.Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Addresses #<issue_number>