Add hidehelp toggle #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to hide help for commands that a user does not have permissions for. This affects
[p]helpand[p]help commandwhen typed in a channel, but has no effect on[p]helpor[p]help commandtyped in DMs. The toggle commands are[p]p hidehelp onand[p]p hidehelp off.I have a working version as a separate cog here:
(the command names are different, but the functionality is the same)
https://github.com/ritsu/RitsuCogs/tree/master/helpless
The way it works is it sets
bot.formatterto a derived class that inherits fromcommands.HelpFormatterand overrides theHelpFormatter.format()andHelpFormatter.filter_command_list()methods. The toggle command just switches bot.formatter betweencommands.HelpFormatterand the derived class.It was suggested that I PR this here. I'm happy with either merging it or keeping it as a separate cog, though I think merging makes more sense.