Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Typos spell checker' extension is not available in Code - OSS for Alpine Linux 64 bit. #132

Closed
andar1an opened this issue Nov 8, 2024 · 7 comments · Fixed by #133
Closed

Comments

@andar1an
Copy link

andar1an commented Nov 8, 2024

May be nice to make this available on Alpine and other musl based distros. Target example is x86_64-unknown-linux-musl.

I haven't looked at code, just noticed this today.

@tekumara
Copy link
Owner

tekumara commented Nov 8, 2024

There’s already a musl binary available, does it not work for you?

@tekumara
Copy link
Owner

tekumara commented Nov 8, 2024

See #112

@andar1an
Copy link
Author

andar1an commented Nov 8, 2024

Oh interesting, maybe alpine is just not enabled as platform specific extension? I don't know how open vsix works or vscode store, I am moving away from Ide's but noticed this today.

The warning is the issue title verbatim.

@andar1an
Copy link
Author

andar1an commented Nov 8, 2024

1731107973-wayshot

See screenshot, I don't think this is the same as linked issue.

@tekumara
Copy link
Owner

tekumara commented Nov 9, 2024

Ah so it looks like there is a specific alpine-x64 target, distinct from linux-x64 (which is the musl binary):

❯ npx vsce publish --help
Usage: vsce publish [options] [version]

Publishes an extension

Options:
  -p, --pat <token>                Personal Access Token (defaults to VSCE_PAT environment variable)
  --azure-credential               Use Microsoft Entra ID for authentication
  -t, --target <targets...>        Target architectures. Valid targets: win32-x64, win32-arm64, linux-x64, linux-arm64, linux-armhf, darwin-x64, darwin-arm64, alpine-x64,
                                   alpine-arm64, web

This is for publishing to the vscode marketplace but I expect open-vsx is the same.

tekumara pushed a commit that referenced this issue Nov 9, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.1.30](v0.1.29...v0.1.30)
(2024-11-09)


### Features

* publish vscode alpine-x64 package
([6088bc1](6088bc1)),
closes [#132](#132)


### Chores

* **deps:** bump typos-cli from 1.27.0 to 1.27.2
([#131](#131))
([11f549d](11f549d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: potatobot-prime[bot] <132267321+potatobot-prime[bot]@users.noreply.github.com>
@tekumara
Copy link
Owner

tekumara commented Nov 9, 2024

This has now been published to the open vsx registry as an Alpine Linux 64 bit package. Hopefully that works for you.

@andar1an
Copy link
Author

andar1an commented Nov 9, 2024

I can check tmr and update you if still seeing error, ty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants