Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error LNK2019: unresolved external symbol _GetLogicalDrives #33

Closed
tekumara opened this issue Feb 5, 2024 · 2 comments · Fixed by #34
Closed

error LNK2019: unresolved external symbol _GetLogicalDrives #33

tekumara opened this issue Feb 5, 2024 · 2 comments · Fixed by #34

Comments

@tekumara
Copy link
Owner

tekumara commented Feb 5, 2024

The windows 32-bit release build is failing with:

  = note: libtypos_lsp-dda1aca84f2c5a63.rlib(typos_lsp-dda1aca84f2c5a63.typos_lsp.eadda57265c587f5-cgu.15.rcgu.o) : error LNK2019: unresolved external symbol _GetLogicalDrives referenced in function __ZN9typos_lsp5state12BackendState13update_router17h50646cd0761b34f9E.llvm.11224600574678780910
          D:\a\typos-vscode\typos-vscode\target\i686-pc-windows-msvc\release\deps\typos_lsp.exe : fatal error LNK1120: 1 unresolved externals

This is blocking the release.
@tekumara tekumara mentioned this issue Feb 5, 2024
Closed
@tekumara
Copy link
Owner Author

tekumara commented Feb 5, 2024

This looks relevant ogham/rust-ansi-term#33

@tekumara
Copy link
Owner Author

tekumara commented Feb 5, 2024

Alternatively we could switch to the windows crate (which supersedes the winapi crate) as per ogham/rust-ansi-term#31 (comment)

@potatobot-prime potatobot-prime bot mentioned this issue Feb 5, 2024
Merged
tekumara pushed a commit that referenced this issue Feb 5, 2024
@potatobot-prime
chore(main): release 0.1.12 (#34)
68f1d4c 
🤖 I have created a release *beep* *boop*
---


##
[0.1.12](v0.1.11...v0.1.12)
(2024-02-05)


### Features

* typos 1.18.0 with January 2024 dictionary changes
([dfb3e55](dfb3e55))


### Bug Fixes

* error LNK2019: unresolved external symbol _GetLogicalDrives
([6ec5abf](6ec5abf)),
closes [#33](#33)
* use config file when workspace folder absent
([79ae446](79ae446)),
closes [#31](#31)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: potatobot-prime[bot] <132267321+potatobot-prime[bot]@users.noreply.github.com>
This was referenced Mar 26, 2024
Merged
Closed
This was referenced Sep 23, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tekumara