Skip to content

Commit

Permalink
Run rubocop in github actions rather than in codeclimate
Browse files Browse the repository at this point in the history
  • Loading branch information
printercu committed Dec 30, 2023
1 parent ddf1ccb commit 056f055
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 14 deletions.
4 changes: 0 additions & 4 deletions .codeclimate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,3 @@ checks:
method-complexity:
config:
threshold: 6 # should be just fine

plugins:
rubocop:
enabled: true
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@ name: Lint & Test
on: [push, pull_request]

jobs:
# lint:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v3
# - uses: ruby/setup-ruby@v1
# with:
# ruby-version: '3.0'
# bundler-cache: true
# - run: bundle exec rubocop
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.2'
bundler-cache: true
- run: bundle exec rubocop

test:
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ AllCops:
Exclude:
- gemfiles/*
- tmp/*
- vendor/**/* # for github actions

Gemspec/DevelopmentDependencies: {Enabled: false}

Expand Down
3 changes: 2 additions & 1 deletion spec/telegram/bot/config_methods_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@

context 'when bot is not configured' do
let(:config) { super().except(:default) }
it { should raise_error(/bot is not configured/) }
it { should
raise_error(/bot is not configured/) }
end
end

Expand Down

0 comments on commit 056f055

Please sign in to comment.