-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metrics; fix latency check; latency time in sec #45
Conversation
rdy for review |
@ALL should we separate the checks in dedicated packages e.g. checks/health, checks/latency? checks files are getting bigger, we could outsource e.g the metrics part in a separate file. |
@y-eight You're right, checks are getting heavy. Breaking it down into Additionally thanks for fixing the rest of the latency times that were incorrect. |
Signed-off-by: Bruno Bressi <bruno.bressi@telekom.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed some commits regarding doc grammar and I've changed a docstring. I only have some questions and concerns regarding concurrency in some functions.
Otherwise than that, everything seems OK.
Signed-off-by: Bruno Bressi <bruno.bressi@telekom.de>
Motivation
Implements #32 and fixes the latency tests.
Checks can register Prometheus collectors at sparrow lvl. Therefore a new Interface func has been added to the Checks interface.
The latency time has been changed from Microseconds to Seconds. The default & best practice for promethus is seconds. This will affect the API as well.
Changes
For additional information look at the commits.