test: ensure package tests run when they should#148
Merged
patrick-stephens merged 3 commits intomainfrom Dec 10, 2025
Merged
Conversation
Signed-off-by: Patrick Stephens <pat@fluent.do>
Signed-off-by: Patrick Stephens <pat@fluent.do>
patrick-stephens
added
build-packages
Signed-off-by: Patrick Stephens <pat@fluent.do>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on work from #147 - RPM tests were working locally but not in CI.
Now we specify an env var to exist when packages should be installed so this is treated as a failure and not just skipped.
Summary by cubic
Make package functional tests fail when the agent package is expected but missing, preventing false passes in CI. This adds an env flag to the test container and updates tests to respect it.
Written for commit cedd068. Summary will update automatically on new commits.