Skip to content

Comments

ci: replace manual preflight tool installation with openshift-tools-installer#70

Merged
patrick-stephens merged 1 commit intotelemetryforge:mainfrom
JackPGreen:Replace-manual-`preflight`-tool-installation-with-`openshift-tools-installer`
Oct 25, 2025
Merged

ci: replace manual preflight tool installation with openshift-tools-installer#70
patrick-stephens merged 1 commit intotelemetryforge:mainfrom
JackPGreen:Replace-manual-`preflight`-tool-installation-with-`openshift-tools-installer`

Conversation

@JackPGreen
Copy link
Contributor

@JackPGreen JackPGreen commented Oct 24, 2025

The CI workflows manually download & install the preflight tool from a specific URL.

RedHat offer a openshift-tools-installer action to abstract this away.

Greptile Overview

Updated On: 2025-10-24 15:48:19 UTC

Greptile Summary

This PR modernizes the CI workflows by replacing manual preflight tool installation with Red Hat's official openshift-tools-installer action.

  • Replaced manual curl-based download and installation of preflight-linux-amd64 with redhat-actions/openshift-tools-installer@v1
  • Updated binary invocation from ./preflight-linux-amd64 to preflight (now available in PATH)
  • Applied consistently across both publish and test workflows
  • Simplifies maintenance by leveraging Red Hat's official action for tool management

Confidence Score: 5/5

  • This PR is safe to merge - clean refactoring that improves maintainability without functional changes
  • The changes are straightforward and improve code quality by using an official Red Hat action instead of manual installation. The action handles download, installation, and PATH configuration automatically. Both workflows are updated consistently, and the functionality remains identical.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/call-publish-release-images.yaml 5/5 Replaced manual preflight installation with redhat-actions/openshift-tools-installer@v1 action and updated binary invocation from ./preflight-linux-amd64 to preflight
.github/workflows/call-test-containers.yaml 5/5 Replaced manual preflight installation with redhat-actions/openshift-tools-installer@v1 action and updated binary invocation from ./preflight-linux-amd64 to preflight

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Workflow
    participant Installer as openshift-tools-installer Action
    participant GitHub as GitHub Releases
    participant Preflight as Preflight Binary
    participant RedHat as Red Hat Certification API

    Note over GH: call-publish-release-images.yaml
    GH->>Installer: Request preflight: latest
    Installer->>GitHub: Download preflight binary
    GitHub-->>Installer: Return preflight-linux-amd64
    Installer->>Installer: Install & add to PATH
    Installer-->>GH: Tool ready
    GH->>Preflight: preflight check container
    Preflight->>RedHat: Submit certification request
    RedHat-->>Preflight: Certification result
    Preflight-->>GH: Check complete

    Note over GH: call-test-containers.yaml
    GH->>Installer: Request preflight: latest
    Installer->>GitHub: Download preflight binary
    GitHub-->>Installer: Return preflight-linux-amd64
    Installer->>Installer: Install & add to PATH
    Installer-->>GH: Tool ready
    GH->>Preflight: preflight check container
    Preflight-->>GH: Validation result
Loading

@JackPGreen JackPGreen requested a review from a team October 24, 2025 15:42
@JackPGreen JackPGreen force-pushed the Replace-manual-`preflight`-tool-installation-with-`openshift-tools-installer` branch from 26fd9f7 to d76d298 Compare October 24, 2025 15:43
…staller`

The CI workflows manually download & install the `preflight` tool from a specific URL.

RedHat offer a [`openshift-tools-installer` action](https://github.com/redhat-actions/openshift-tools-installer) to abstract this away.
@JackPGreen JackPGreen force-pushed the Replace-manual-`preflight`-tool-installation-with-`openshift-tools-installer` branch from d76d298 to 275c363 Compare October 24, 2025 15:45
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent @JackPGreen , thanks for this and removing my overuse of bash which is always an improvement!

@patrick-stephens
Copy link
Contributor

Ah this exposed a few permissions issues around external contribution but I'll sort. I'm happy with the actual change.

@patrick-stephens patrick-stephens changed the title Replace manual preflight tool installation with openshift-tools-installer ci: replace manual preflight tool installation with openshift-tools-installer Oct 25, 2025
@patrick-stephens patrick-stephens merged commit da0ba2b into telemetryforge:main Oct 25, 2025
26 of 34 checks passed
@JackPGreen JackPGreen deleted the Replace-manual-`preflight`-tool-installation-with-`openshift-tools-installer` branch October 25, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants