ci: replace manual preflight tool installation with openshift-tools-installer#70
Merged
patrick-stephens merged 1 commit intotelemetryforge:mainfrom Oct 25, 2025
Conversation
26fd9f7 to
d76d298
Compare
…staller` The CI workflows manually download & install the `preflight` tool from a specific URL. RedHat offer a [`openshift-tools-installer` action](https://github.com/redhat-actions/openshift-tools-installer) to abstract this away.
d76d298 to
275c363
Compare
patrick-stephens
approved these changes
Oct 25, 2025
Contributor
patrick-stephens
left a comment
There was a problem hiding this comment.
Excellent @JackPGreen , thanks for this and removing my overuse of bash which is always an improvement!
Contributor
|
Ah this exposed a few permissions issues around external contribution but I'll sort. I'm happy with the actual change. |
preflight tool installation with openshift-tools-installerpreflight tool installation with openshift-tools-installer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI workflows manually download & install the
preflighttool from a specific URL.RedHat offer a
openshift-tools-installeraction to abstract this away.Greptile Overview
Updated On: 2025-10-24 15:48:19 UTC
Greptile Summary
This PR modernizes the CI workflows by replacing manual
preflighttool installation with Red Hat's officialopenshift-tools-installeraction.preflight-linux-amd64withredhat-actions/openshift-tools-installer@v1./preflight-linux-amd64topreflight(now available in PATH)Confidence Score: 5/5
Important Files Changed
File Analysis
preflightinstallation withredhat-actions/openshift-tools-installer@v1action and updated binary invocation from./preflight-linux-amd64topreflightpreflightinstallation withredhat-actions/openshift-tools-installer@v1action and updated binary invocation from./preflight-linux-amd64topreflightSequence Diagram
sequenceDiagram participant GH as GitHub Workflow participant Installer as openshift-tools-installer Action participant GitHub as GitHub Releases participant Preflight as Preflight Binary participant RedHat as Red Hat Certification API Note over GH: call-publish-release-images.yaml GH->>Installer: Request preflight: latest Installer->>GitHub: Download preflight binary GitHub-->>Installer: Return preflight-linux-amd64 Installer->>Installer: Install & add to PATH Installer-->>GH: Tool ready GH->>Preflight: preflight check container Preflight->>RedHat: Submit certification request RedHat-->>Preflight: Certification result Preflight-->>GH: Check complete Note over GH: call-test-containers.yaml GH->>Installer: Request preflight: latest Installer->>GitHub: Download preflight binary GitHub-->>Installer: Return preflight-linux-amd64 Installer->>Installer: Install & add to PATH Installer-->>GH: Tool ready GH->>Preflight: preflight check container Preflight-->>GH: Validation result